Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to de_DE.po #10889

Closed
wants to merge 2 commits into from
Closed

Conversation

Mr-Kanister
Copy link
Contributor

I appreciate the time @cedecode invested into this (#10660, #10673, #10767, #10863). Despite a lot of useful contributions there are unfortunately (besides many subjectively unnecessary) some incorrect changes. I annotated most of them below and am open for discussion.
(I noticed at the end that you are coming from austria, which may be the reason for some regional differences. In my opinion this translation should be a high german translation.)

Changes:

  • All: Update de_DE.po #10660
    1. "All item sync failures have been marked as "ignored"":
      "Alle fehlerhaft synchronisierten Elemente wurden als „ignoriert“ markiert." translates to "All incorrectly synchronized elements were marked as "ignored"", which is wrong.
    2. "Automatically delete notes in the trash after a number of days":
      "Automatisch Notizen im Papierkorb löschen nach einer Anzahl von Tagen" is grammatically unclean.
    3. "Automatically switch theme to match system theme":
      There are comments on this one discussing the use of "Design". Why did you silently change it without editing the comment? I'm fine with the change but then please add a comment on why you did so.
    4. "Change application layout" & "Reset application layout":
      Why change it, when "Layout" is a german word? You use "Erscheinungsbild" in another context ("design"). This is something different, it is really the layout which gets changed here, not the theme/design.
    5. "Ctrl-click to open" & "Ctrl-click to open: %s":
      Ctrl is different to Cmd. If this indeed uses the cmd key on mac, this should be mentioned in the english base translation.
    6. "Export debug report":
      A debug report (Ereignisbericht) is not an error report (Fehlerbericht).
  • All: Update de_DE.po (small improvements) #10673
    1. "Any email sent to this address will be converted into a note and added to your collection. The note will be saved into the Inbox notebook", "Delete the Inbox notebook?\n\n If you delete the inbox notebook, any email that's recently been sent to it may be lost.", ...:
      "Email" is grammatically incorrect (it may be in austria), while "E-Mail" was correct. According to the Duden "Das E-Mail" (neuter) is used in south germany, switzerland and austria. Because this is a high german translation "Die E-Mail" (feminine) is better suited.
    2. "Show sort order buttons":
      I don't see the reason to untranslate the word "buttons".
    3. "Use this to rebuild the search index if there is a problem with search. It may take a long time depending on the number of notes.":
      "a long time" ("eine lange Zeit") isn't "a little bit longer" ("etwas länger").
    4. "Warning: not all resources shown for performance reasons (limit: %s).":
      "performance reasons" ("Leistungsgründe"/"Performanzgründe") aren't necessarily capacity reasons ("Kapazitätsgründe").
  • Update de_DE.po #10863
    1. "Cannot share encrypted notebook with recipient %s because they have not enabled end-to-end encryption. They may do so from the screen Configuration > Encryption.":
      The "Configuration" menu point is translated with "Optionen" in the whole translation file.
    2. "The Web Clipper is a browser extension that allows you to save web pages and screenshots from your browser.":
      I don't see the reason to untranslate the word "Bildschirmfotos".
    3. "These plugins enhance the Markdown renderer with additional features. Please [...]":
      The old translation was more correct than the new one. I merged them.

Debatable (not changed):

  • I struggled with the problem regarding "Synchronisierung"/"Synchronisation", too. Both are fine, however according to Duden the first one is the original one while the latter one came from the english language. A uniform solution would be perfect but unfortunately it's hard to be consistent through the whole translation.
  • All: Update de_DE.po #10660
    1. "Are you sure you want to renew the authorisation token?":
      Here you change "Berechtigungstoken" to "Autorisierungstoken" while in the following texts you use "Berechtigungstoken" again:

      • "Authentication was not completed (did not receive an authentication token)."
      • "Cannot refresh token: authentication data is missing. Starting the synchronisation again may fix the problem."

      While beeing unclear in the english language ("authorisation token" vs "authentication token" etc.), a uniform solution would be perfect.

Thank you for the rest of the translations!

I think it should be considered adding some guidelines as comments above the translation, so that it gets more uniform. However those should be discussed in the forum first.

Sidenote: The problem regarding "Sie"/"Du" still exists (https://discourse.joplinapp.org/t/translation-questions/36429/3).

Correct some translations
@cedecode
Copy link
Contributor

Thank you @Mr-Kanister for your thoughts and work. I really appreciate it and agree with almost all of it.
My goal was to raise the percentage and reduce inconsistencies, unfortunately some remained unresolved or raise new discussions. I'll address some of your points and add suggestions to the discussion.

Austrian German:

There are so few differences in this application that I don't think a separate language variant (de_AT) is necessary. However, we have come across a difference in the article for e-mail (feminine vs. neuter). It is of course logical to use the variant of de_DE (fem.).

  • I would argue in favour of the plural as a compromise: "Any email sent to this address..." -> "Alle E-Mails, die an diese Adresse gesendet werden..."
  • Postscript 1: "E-Mail" is the official spelling, thank you!
  • Postscript 2: Should we translate "inbox" as "Posteingang"? However, I can only find two places with inbox, the dialogue box and the help text. Presumably it is an automatically generated notebook – I don't know where its name is defined and where it can be translated.

translations:

  • screenshot -> Screenshot/Bildschirmfoto: Both are permitted, I find "Screenshot" more familiar from everyday life. It seems to be the case that Windows uses "Screenshots" and Mac "Bildschirmfoto" (without proof).
  • button -> Button/Knopf: The button as a control element of a GUI is clearly "Button" for me. Subjectively, "Knopf" sounds more like a beginner user. (Don't be angry with me, that doesn't apply to you. I'm just saying what I associate with it).
  • performance -> Performanz/Leistung/Kapazität: I admit that "Kapazität" makes you think of storage and not the intended computing. Suggestion: "Leistung" sounds more familiar than "Performanz".

The "Configuration" menu point is translated with "Optionen" in the whole translation file.

Please look at this again! For example, in line 1072, "configuration" was translated as "Konfiguration" (it's the button in the sidebar).
My principle was: "settings" -> "Einstellungen", "options" -> "Optionen", "configuration" -> "Konfiguration". These are difficult to distinguish, but correspond to the English default.

While beeing unclear in the english language ("authorisation token" vs "authentication token" etc.), a uniform solution would be perfect.

Maybe we should go back to "Autorisierungstoken" until we have found a better solution for this. "Berechtigung" may be nice for authorisation (not for authentication), but we should probably clarify the distinction in English first.

Thanks for the tip about the discussion forum and maintaining the comments!

@cedecode
Copy link
Contributor

One more point @Mr-Kanister:

Hyphens:

"Joplin Server Passwort" with spaces only: I tried to avoid a translation pattern like "car wash" -> "Auto Wäsche". I think "Joplin-Server-Passwort" and "Web-Clipper-Dienst” would be most correct German spelling (along the examples "Social-Media-Account", "Do-it-yourself-Programm"). Doubt: With the hyphen, we would change the "brand names" (on the other hand, this is also done with "Deutsche-Bank-Hochhaus").

@Mr-Kanister
Copy link
Contributor Author

Tl;dr for the dev-team:

  1. The name of the inbox notebook seems to be hardcoded. Should this be added to the translation files?
  2. It seems like the options are sometimes called options and sometimes configuration. Should this be fixed in the code? If yes, which should be chosen?
  3. The english translation sometimes mixes up authentication and authorisation. This should be uniform using e. g. this resource: https://www.okta.com/identity-101/authentication-vs-authorization/ (e. g. here:
    "Please open the following URL in your browser to authenticate the "
    authorise should be used). Unfortunately in german it is even harder as we have to decide between "Authentifizierung", "Authentisierung" and "Autorisierung" (described e. g. here: https://www.dr-datenschutz.de/authentisierung-authentifizierung-und-autorisierung/)
  4. How exactly should company names be kept? Are we allowed to put hyphens in between? ("Joplin Cloud", "Joplin Server", "Web Clipper", etc. -> "Joplin-Cloud", "Joplin-Server", "Web-Clipper", etc.)

I would argue in favour of the plural as a compromise: "Any email sent to this address..." -> "Alle E-Mails, die an diese Adresse gesendet werden..."

Yes, this is good.

Should we translate "inbox" as "Posteingang"?

Yes, that would be nice, however as you said, the name of the notebook seems to be hardcoded. This should be added to the translation files imo.

Screenshot/Bildschirmfoto: Both are permitted

True, didn't think about that. In my opinion Screenshot is indeed more widely used, however I always try to think of my grandparents, who wouldn't know such a word. Difficult, I don't have a solution yet.

Button/Knopf: The button as a control element of a GUI is clearly "Button" for me. Subjectively, "Knopf" sounds more like a beginner user.

I won't be angry with you because I think exactly the same way like you. The same thing as above applies here, too. We have to decide between germanizing everything as much as possible and a more relaxed translation which uses anglicisms.

"Leistung" sounds more familiar than "Performanz".

Alright, let's go with that.

For example, in line 1072, "configuration" was translated as "Konfiguration"

Good point. Line 1072 regards the mobile app. In the desktop apps (to the best of my knowledge) "Optionen" ist used. This should be uniform across platforms. Unfortunately it isn't uniform even in the english translation (e. g. "Options" [https://github.com/laurent22/joplin/blob/111820c0cfb6f88588fe2f73c8b74de8611a8979/packages/tools/locales/de_DE.po#L3672] vs. "They may do so from the screen Configuration > Encryption." [https://github.com/laurent22/joplin/blob/111820c0cfb6f88588fe2f73c8b74de8611a8979/packages/tools/locales/de_DE.po#L841]). What do you think we should do? In my opinion the first step would be to make it uniform in the english translation.

Maybe we should go back to "Autorisierungstoken" until we have found a better solution for this. "Berechtigung" may be nice for authorisation (not for authentication), but we should probably clarify the distinction in English first.

Yes, I think "Berechtigung" is nice (maybe simpler to understand), but we could also just go with "Autorisierung", I don't know yet...but first the english translation has to be consistent.

I tried to avoid a translation pattern like "car wash" -> "Auto Wäsche"

Ah, now I get, what you wanted to do. I thought about that, but was irritated because there still were some strings, which were left out. Regarding the brand names I actually don't know. This is a decision that the dev team has to make.

Add discussed changes
@Mr-Kanister
Copy link
Contributor Author

Mr-Kanister commented Aug 17, 2024

I created a thread regarding guidelines for the german translation. Maybe it gets used, maybe it doesn't, we'll see. @cedecode if you have something to add right now, just comment it there :)

https://discourse.joplinapp.org/t/german-translation-guidelines/39677?u=mrkanister

@Mr-Kanister Mr-Kanister marked this pull request as draft August 17, 2024 18:59
@cedecode
Copy link
Contributor

I agree with your changes!

Here's the comment how I translated "theme": Before my changes, it was mostly translated as "Design", once as "Themes", so a standardisation made sense. Looking at applications didn't help (VLC: Style, Firefox: Theme, Inkscape: Thema, Office: Design, etc.). Windows simply uses "Farben" (colors), Mac OS "Erscheinungsbild". My approach was to have continuity in at least one OS.

In the desktop apps (to the best of my knowledge) "Optionen" ist used. This should be uniform across platforms.

On Mac OS, the menu item is called "Einstellungen" (preferences), perhaps inherited from the OS, and then I end up in a window called "Optionen" (options). Maybe there are limits to what we can standardise.

Thanks for your guidelines! If I have an idea, I'll add it.

@Mr-Kanister
Copy link
Contributor Author

On Mac OS, the menu item is called "Einstellungen" (preferences), perhaps inherited from the OS, and then I end up in a window called "Optionen" (options). Maybe there are limits to what we can standardise.

That is interesting, would you like to share a screenshot with me on how the whole menu at the top looks like in Joplin? I don't have a mac on hand...

@cedecode
Copy link
Contributor

would you like to share a screenshot with me on how the whole menu at the top looks like in Joplin?

Same principle in English: menu "Preferences", window "Options" (even if this screenshot is in German)

joplin-einstellungen

@Mr-Kanister
Copy link
Contributor Author

This is how it looks on Windows, does this menu (Werkzeuge, Optionen) exist at yours?

image

@cedecode
Copy link
Contributor

cedecode commented Aug 18, 2024

This is how it looks on Windows, does this menu (Werkzeuge, Optionen) exist at yours?

No, first entry is "Notiz-Anhänge", there is no duplicate of Optionen/Einstellungen.

@laurent22
Copy link
Owner

Same principle in English: menu "Preferences", window "Options" (even if this screenshot is in German)

This is a limitation of the app rather than a problem with the translation. I guess if we fix this issue, the translation will automatically apply

@laurent22
Copy link
Owner

Hello, I'm going to close this PR as I'm trying to keep a relatively clear PR backlog so I prefer not to leave drafts open for too long.

If there are doubts about how the German translation should be done I suggest discussing it on the forum first and get to a consensus, then we can re-open the pull request (or feel free to create a new one). Or if you think that this PR is good to merge let me know and I'll reopen and merge.

@laurent22 laurent22 closed this Aug 22, 2024
@Mr-Kanister
Copy link
Contributor Author

Mr-Kanister commented Aug 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants