Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Update plugin compatibility layer to allow more legacy plugins (e.g. Markdown Prettier) to run #11033

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request adds .getDoc to the CodeMirror 5 emulation layer, which is required by the markdown-prettier plugin.

Testing plan

  1. Add markdown-prettier as a development plugin.
    • Note: Locally, I tested with a version that uses a newer version of prettier and Joplin plugin template.
  2. Restart Joplin.
  3. Click the "format" button.
  4. Verify that the note is formatted
  5. Install Rich Markdown (regression testing).
  6. Restart Joplin.
  7. Enable focus mode.
  8. Verify that non-active lines are still faded.

This has been tested successfully on Fedora 40.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Update plugin compatibility layer to allow Markdown Prettier to run Desktop: Update plugin compatibility layer to allow more legacy plugins (e.g. Markdown Prettier) to run Sep 12, 2024
@laurent22 laurent22 merged commit c897cc1 into laurent22:dev Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants