New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window manager icon on linux #1110

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@CalebJohn
Copy link
Contributor

CalebJohn commented Jan 9, 2019

This was a weird one that I suspect will come up again when electron-builder is updated. For some reason the resources that are specified by extraResources in package.json are placed one level up from the app directory even though they initially reside in the app directory itself. Unfortunately this fix means that the icon is messed up when running joplin in debug mode.

I also added a desktop parameter into package.json this makes sure that the .desktop file generated by the appimage (if used) will have the correct icon name.

Fixes #251

@laurent22 laurent22 merged commit 88a9d5e into laurent22:master Jan 9, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Jan 9, 2019

Thanks for the fix, and let's review if it gets broken in a future electron-builder release.

@CalebJohn CalebJohn deleted the CalebJohn:proper-icons branch Jan 9, 2019

@foxmask

This comment has been minimized.

Copy link
Collaborator

foxmask commented Jan 11, 2019

thanks ; works great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment