Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: handle ESC key press to cancel the NotePropertiesDialog #1125

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@joybinchen
Copy link
Contributor

joybinchen commented Jan 14, 2019

It's a handy feature, but not not so important.
I'm not sure when you guys will accept PR for new features again.
Just keep it until you are not so busy.
Keep up the good work.

@foxmask foxmask changed the title Desktop: handle ESC key press to cancle the NotePropertiesDialog Desktop: handle ESC key press to cancel the NotePropertiesDialog Jan 14, 2019

style={styles.button}
onClick={this.okButton_click}
ref="okButton"
onKeyDown={(event) => this.onKeyDown(event)}

This comment has been minimized.

@laurent22

laurent22 Jan 15, 2019

Owner

You can simply do onKeyDown={this.onKeyDown} since the handler is already bound to this component, and that will avoid an anonymous function.

This comment has been minimized.

@joybinchen

joybinchen Jan 16, 2019

Author Contributor

You are right. PR updated.

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Jan 15, 2019

Thanks for the PR, this kind of usability improvements are indeed useful. I've left a few comments, so please have a look at them.

@joybinchen joybinchen force-pushed the joybinchen:joybin-esc-notePropertiesDialog branch from bd0819a to 1f04142 Jan 16, 2019

@joybinchen joybinchen force-pushed the joybinchen:joybin-esc-notePropertiesDialog branch from 1f04142 to 89294eb Jan 16, 2019

@laurent22 laurent22 merged commit 739fb2c into laurent22:master Jan 16, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Jan 16, 2019

Perfect, thank you @joybinchen!

@joybinchen joybinchen deleted the joybinchen:joybin-esc-notePropertiesDialog branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.