Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Resolves #6088: Highlight global search matches in the Rich Text Editor #11361

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 9, 2024

Summary

This pull request highlights search matches in the Rich Text Editor.

Note: This pull request was originally opened in #9784, but closed due to a Chromium bug that is now fixed.

Fixes #6088.

Note

This pull request is a draft, pending automated tests and further research into the accessibility of this approach.

Notes

  • Existing issue observed: Opening a secondary window clears highlighted search terms from an ongoing search.
    • This issue seems to also happen for the Markdown editor.
  • Accessibility issues?: According to the spec, browsers should expose highlights with the API used by this pull request to screen readers. However, at least on Linux, this doesn't seem to happen (perhaps due to this upstream bug).

Screenshot

screenshot: Shows content highlighted inside and outside code blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search string not highlighted in rich editor
2 participants