Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when deleting notebook or tag, display name #1253

Merged
merged 1 commit into from Feb 24, 2019

Conversation

Projects
None yet
2 participants
@tessus
Copy link
Collaborator

tessus commented Feb 22, 2019

The delete dialog for notebooks and tags does not display the name of the item to be deleted.
This can lead to an undesired result.

closes #1245

The dialog now looks like this:

delete notebook

screen shot 2019-02-22 at 01 35 58

delete tag

screen shot 2019-02-22 at 01 36 47


Please note that I do not know how to update the .pot and .po files. Is there a script to do this? I doubt this is a manual process.

when deleting notebook or tag, display name
The delete dialog for notebooks and tags does not display the name of the item to be deleted.
This can lead to an undesired result.

closes #1245

@tessus tessus requested a review from laurent22 Feb 23, 2019

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Feb 24, 2019

Makes sense, thanks for the update!

@laurent22 laurent22 merged commit c34872b into laurent22:master Feb 24, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@tessus

This comment has been minimized.

Copy link
Collaborator Author

tessus commented Feb 24, 2019

For the future, can you please tell me how to update the .pot and .po files? Or is this something that you want to do yourself?

Btw, I've notice the following entries in the .po files, which don't seem right:

&File
&Edit
&Vieew
&Tools
&Help

Afaik the & character denotes the shortcut letter. So how are translators to choose one in a translation? It could be that the first letter shows up twice in a translation. Also, wouldn't they have to use the same letter as in the source? I don't think that this is something a translator can do, unless there are specific instructions how to handle & characters.

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Feb 25, 2019

The "&" is to fix this bug: electron/electron#11106 Menu shortcuts are language dependent so it's indeed usually done as part of the localisation process. I'd expect most translators will just leave it as the first characters and if that causes problem, we can look into it at that time.

To update the translation it's Tools/build-translations.js but it's something that I usually do once just before a build so that there's not too many commits to update translations.

@tessus

This comment has been minimized.

Copy link
Collaborator Author

tessus commented Feb 25, 2019

The "&" is to fix this bug

Ah, I see.

it's indeed usually done as part of the localisation process

This seems a bit dangerous. Let's say a person uses the first letters as the shortcuts. Another person doesn't like them and updates the localization file and changes the shortcuts. All of a sudden the next version of Joplin has different shortcuts.

I usually do once just before a build

Thanks for the info. In this case I won't touch it.

@tessus tessus deleted the tessus:delete-improvements branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.