Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Resets the undo manager when creating new notes. Fixes #355 #1495

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
2 participants
@innocuo
Copy link
Collaborator

commented May 6, 2019

If you go to create a new note, and press ctrl+z (undo), it loads the contents of the previously selected note. This was fixed for existing notes, but not for new notes. The reference issue is #355

@innocuo

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

as a sidenote, a couple lines above this fix In NoteText.jsx, there's a comment:

// Note: calling undoManager.reset() doesn't work

It seems that reset is not enough, but this did work for me:

const undoManager = this.editor_.editor.getSession().getUndoManager();
undoManager.reset();
this.editor_.editor.getSession().setUndoManager(undoManager);

or simply

this.editor_.editor.getSession().setUndoManager(undoManager);

I didn't change this as the existing code does fix the undo issue anyway.

@laurent22 laurent22 merged commit 5934f2f into laurent22:master May 6, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@laurent22

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

Thanks for the fix!

@innocuo innocuo deleted the innocuo:dev-undo-new-note branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.