Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multimd-table and enable options #1586

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
3 participants
@CalebJohn
Copy link
Contributor

commented May 26, 2019

@laurent22 laurent22 merged commit a0fb99d into laurent22:master May 27, 2019

@CalebJohn CalebJohn deleted the CalebJohn:multimd branch May 27, 2019

@tessus

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

@CalebJohn I just noticed that you didn't update the package in ReactNativeClient/package.json. I went through the package.json in Electron/app and ReactNativeClient and they are not consistent.
Components like react and redux are using different versions. I don't think this should be the case, but maybe I'm missing something here.
I wanted to create a PR, but stumbled about so many differences that I'm not sure what to do.

@CalebJohn

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

Nice catch @tessus that was an oversight on my part. Fixed in #1597

As for the other discrepancies it looks to me like the result of similar oversights and possibly out of necessity for bug fixes etc. While I think it would be good to have everything on up-to-date versions, theres also an element of, if it ain't broke don't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.