Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Change template prompt to sans and sort templates #1806

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@CalebJohn
Copy link
Contributor

commented Aug 15, 2019

Addresses this topic in the forum.

Note: I wasn't able to reproduce his second issue (sort order). But I put some sorting code in, hopefully that will fix it.

@@ -56,7 +56,7 @@ TemplateUtils.loadTemplates = async function(filePath) {
});
}

return templates;
return templates.sort((a, b) => { return a.label.localeCompare(b.label); });

This comment has been minimized.

Copy link
@laurent22

laurent22 Aug 15, 2019

Owner

Shouldn't we sort in a case insensitive way? (not sure if localeCompare does this)

This comment has been minimized.

Copy link
@CalebJohn

CalebJohn Aug 16, 2019

Author Contributor

You're probably right, I just copied this function from the tag sorting. I'll look into a better method for sorting.

This comment has been minimized.

Copy link
@CalebJohn

CalebJohn Aug 16, 2019

Author Contributor

I changed this by adding the sensitivity option.

@CalebJohn

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Okay should be good to ship now.

@tessus tessus added the 💻 desktop label Aug 16, 2019

@laurent22

This comment has been minimized.

Copy link
Owner

commented Aug 29, 2019

Looks good now, thanks @CalebJohn!

@laurent22 laurent22 merged commit 9a4f4cb into laurent22:master Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.