Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (5)
@laurent22 laurent22 Mar 26, 2020
Likewise, please could you add two test cases: - for str = "" - and for when there's no whitespace after the specified index
Outdated
CliClient/tests/StringUtils.js
@laurent22 laurent22 Mar 26, 2020
Could you add a test case for the empty array please?
CliClient/tests/ArrayUtils.js
@laurent22 laurent22 Mar 24, 2020
Please add a comment to describe: - What this function does - What are the parameters - What is the output
Outdated
ReactNativeClient/lib/string-utils.js
anjulalk
@laurent22 laurent22 Mar 24, 2020
Could you refactor this into a function to make it clearer what it does?
Outdated
ElectronClient/plugins/GotoAnything.jsx
anjulalk
@laurent22 laurent22 Mar 24, 2020
As this is almost the same code as makeTitleSearchQuery, could you refactor both in a single `makeSearchQuery(query, field)` where field can be either "title" or "body"?
Outdated
ElectronClient/plugins/GotoAnything.jsx