Jump to conversation
Unresolved conversations (5)
@laurent22 laurent22 Apr 9, 2020
We can't load the preview here. As discussed in the forum, the preview should be loaded dynamically, and only for the currently visible notes, for performance reasons.
ReactNativeClient/lib/models/Note.js
anihm136
@laurent22 laurent22 Apr 9, 2020
You can use DOM functions here as that will break in mobile, cli and probably test units. Also we need to extract the preview from the Markdown text, not from HTML. You can use markdown-it to parse the Markdown to a token stream, and from that you could extract the plain text.
ReactNativeClient/lib/models/Note.js
anihm136
@laurent22 laurent22 Apr 9, 2020
No duplicated logic please
ReactNativeClient/lib/models/BaseItem.js
@laurent22 laurent22 Apr 9, 2020
Why "my"?
ElectronClient/gui/NoteList.jsx
anihm136
@laurent22 laurent22 Apr 9, 2020
NoteText is unrelated to NoteList so that code should not be here.
ElectronClient/gui/NoteText.jsx
Resolved conversations (0)