All: Fix filters when language is in Korean #3947
Conversation
|
Do the filters support Asian languages? After this fix, what happens if someone searches for "tag:여보세요" ? |
Yes, because we are using the SQL LIKE operator to match the tag names. We can also put a wildcard anywhere in the string. Before this fix, if we search for "tag:여보세요", we'll see the Korean text, change the search type to "basic" and then do a basic search for the empty string. This means all the notes will be returned. (Empty string since after parsing the query, we'll get no actual "text" to search. But maybe this is also a bug, since if we're doing a basic search we should parse "tag:여보세요" as just "text". No reason to interpret it as a filter then.) After this fix, we'll be checking for the presence of Asian language characters in text, title and body terms only. So the search becomes an FTS search and we get back all the notes with tag "여보세요" (as expected). |
|
Bug #3857 is caused because of a different reason. We were removing the diacritics from all the filter values before doing the search. This should be done only for the text, title, and body values. I added a fix for that too in this PR. Queries like |
| try { | ||
| allTerms = filterParser(query); | ||
| } catch (error) { | ||
| console.warn(error); |
There was a problem hiding this comment.
Should we proceed with the rest of the code if there was an error here? What kind of error be thrown in this case?
There was a problem hiding this comment.
You're right, we could throw an error here and exit from this function. But there needs to be a catch statement higher up.
Errors would be invalid filters like -notebook:abc, type:blah , foo:bar etc.
There was a problem hiding this comment.
Yes it seems that getting the error displayed somewhere in the UI wouldn't be that easy, so let's keep it as it is now. A warning is a good start and there's the doc to explain how the query should be formatted.
|
Thanks for the fix @naviji! |
We shouldn't use basic search when the filters like "tag" have a value in languages like Korean.
Otherwise, queries like these won't work.
tag:여보세요
Bug reported here: https://discourse.joplinapp.org/t/search-tag-in-asian-laguage-doesnt-work-properly/11285