Jump to conversation
Unresolved conversations (3)
@laurent22 laurent22 Dec 28, 2020
I would prefer if we don't add this package as it's unsupported, and I expect not necessary. Node buffer supports many formats - is it not possible to use one of its helper functions to load the content?
Outdated
packages/lib/onedrive-api.js
@jonath92 jonath92 Nov 20, 2020
I removed the options.path because this is undefined in case of note and it was not really useful anyway.
packages/lib/onedrive-api.js
@laurent22 laurent22 Nov 20, 2020
I understand why you've done this, but we can't have special cases like this across the codebase with some code using one fetch and other using a different one. Also that code would bypass the retry and timeout mechanism as well as break in the CLI app, which doesn't have a native fetch. If native fetch is better in the desktop app, perhaps the shim can be updated to use it everywhere instead (but that would require extensive testing)? It would also still need to work with the CLI app which is going to use node-fetch. Or perhaps the solution here is to use shim.fetchBlob?
Outdated
packages/lib/onedrive-api.js
laurent22 jonath92
Resolved conversations (0)