Desktop: Fixes #5875: Show error on sync if S3 region is not set #5923
Conversation
|
It was only tested on Linux desktop app. I'm not sure if this affects other platforms. I don't have other platforms for testing. |
Co-authored-by: Helmut K. C. Tessarek <tessarek@evermeet.cx>
Co-authored-by: Helmut K. C. Tessarek <tessarek@evermeet.cx>
| reg.logger().error(error); | ||
| utils.store.dispatch({ | ||
| type: 'SYNC_REPORT_UPDATE', | ||
| report: { errors: [error] }, |
There was a problem hiding this comment.
As it's going to affect all sync targets, and some might output not so useful error messages, please could you add more info? Just error.message = "Could not initialise synchroniser: " + error.message should do.
And that should be done in side-menu-shared too.
There was a problem hiding this comment.
"Could not initialise synchroniser" please. We use British English by default and "acquire synchronizer" doesn't mean much I think.
There was a problem hiding this comment.
@laurent22 Thank you for the comment. All the logs are now in British English.
|
Looks good now, thanks for the fix @shinglyu! |
Shows an error message when syncing if the S3 region is not set
Also shows a message if you try to check sync config in settings:
I also turn a few error log from
infotoerror.This should fix #5875