Desktop: Fixes #9045: Ubuntu: Fix window sometimes doesn't appear on startup

[personalizedrefrigerator]

Explanation

• Electron replaces XDG_CURRENT_DESKTOP with Unity on ubuntu:GNOME, but also stores the original XDG_CURRENT_DESKTOP in ORIGINAL_XDG_CURRENT_DESKTOP.

This change causes shim.isGNOME to also check ORIGINAL_XDG_CURRENT_DESKTOP.

Fixes #9045.

Testing

1. Launch the application using npx electron . (start in release mode)
   • Do not launch from the terminal in VSCode (VSCode is an electron app, and thus also modifies XDG_CURRENT_DESKTOP).
2. Verify that the application window is visible
3. Repeat steps 1 and 2
4. Run shim.isGNOME() in the development tools.

This has been tested on Ubuntu 23.10.

Notes

This may apply to other systems/desktop environments:

In /lib/browser/init.ts,

// Workaround for electron/electron#5050 and electron/electron#9046
process.env.ORIGINAL_XDG_CURRENT_DESKTOP = process.env.XDG_CURRENT_DESKTOP;
if (currentPlatformSupportsAppIndicator()) {
  process.env.XDG_CURRENT_DESKTOP = 'Unity';
}