Chore: Desktop: Fix slow startup issue: defaultPlugins directory not cleaned on rebuild #9785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a slow startup issue caused by multiple copies of default plugins in the
app-desktop/build/defaultPluginsdirectory.This issue was caused by 13da286 and only affects Joplin workspaces that had built default plugins with commits prior to 13da286. As such, it should not affect the released version of v2.14.11.
The issue is fixed by cleaning the build directory before building default plugins.
Testing
git checkout pr/fix-default-plugins-buildyarn tsc && yarn postinstallcd packages/app-desktopyarn startgit checkout HEAD~yarn tsc && yarn postinstallpackages/app-desktop, runyarn startThis has been tested successfully on Ubuntu 23.10.