Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #91: Frequently used file types #112

Merged

Conversation

@kartik-budhiraja
Copy link
Contributor

kartik-budhiraja commented Nov 25, 2019

Fixes #91

  • Added a searchable dropdown for language type
  • The language list is sorted by use frequency
  • Top 3 used languages show up as buttons right next to the dropdown

Screen Shot 2019-11-24 at 11 47 43 PM

@lauthieb

This comment has been minimized.

Copy link
Owner

lauthieb commented Nov 25, 2019

WOW! Thanks a lot @kartik-budhiraja for this wonderful Pull Request! For me it's OK ❤️

@lauthieb

This comment has been minimized.

Copy link
Owner

lauthieb commented Nov 25, 2019

What do you think @benhalpern? It's a pretty cool answer about your issue #91

@lauthieb

This comment has been minimized.

Copy link
Owner

lauthieb commented Nov 25, 2019

@kodaman2 @jack-chapman @bainternet @guastallaigor @stephengroat feel free to add your comments/suggestions/review before I merge this :)

@kodaman2

This comment has been minimized.

Copy link
Contributor

kodaman2 commented Nov 26, 2019

@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor Author

kartik-budhiraja commented Nov 27, 2019

@lauthieb @kodaman2 Let me know if I can help anyways to land this code. :)

@kodaman2

This comment has been minimized.

Copy link
Contributor

kodaman2 commented Nov 28, 2019

There's an ongoing issue in the latest release (master branch) that imo needs to be addressed before any more PRs get merged. #110 if you are interested in reading more about it, basically at some point during the year a commit broke the app. It looks like just the production, as I couldn't duplicate with dev so something tells me is the minified code perhaps but I haven't been able to fix even after reverting the version on some packages.

@lauthieb lauthieb force-pushed the lauthieb:master branch from ebdbaf3 to 29d3a74 Dec 3, 2019
@lauthieb

This comment has been minimized.

Copy link
Owner

lauthieb commented Dec 4, 2019

@kartik-budhiraja Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

@kartik-budhiraja kartik-budhiraja force-pushed the kartik-budhiraja:feature/frequently-used-file-types branch from 580cbe0 to 73047df Dec 8, 2019
@kartik-budhiraja kartik-budhiraja force-pushed the kartik-budhiraja:feature/frequently-used-file-types branch from 73047df to 08a8652 Dec 8, 2019
@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor Author

kartik-budhiraja commented Dec 8, 2019

@lauthieb I fixed the branch, so it should be good to go from my side!

@lauthieb lauthieb merged commit 8a818a5 into lauthieb:master Dec 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.