New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uglifier doesn't load with Ruby 2.4.0 using The Ruby Racer JS runtime #105

Closed
mantas opened this Issue Dec 26, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@mantas

mantas commented Dec 26, 2016

I'm getting following error when launch Rails application with Ruby 2.4.0

TypeError: wrong argument type Class (expected Module)

Running irb and then requiring Uglifier into it throws the same error as well.

@Apokly

This comment has been minimized.

Show comment
Hide comment
@Apokly

Apokly Dec 26, 2016

Same for me.
Backtrace first lines :


/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:23:in `include'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:23:in `block (2 levels) in <top (required)>'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:22:in `class_eval'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:22:in `block in <top (required)>'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:21:in `each'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:21:in `<top (required)>'

Apokly commented Dec 26, 2016

Same for me.
Backtrace first lines :


/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:23:in `include'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:23:in `block (2 levels) in <top (required)>'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:22:in `class_eval'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:22:in `block in <top (required)>'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:21:in `each'
/home/fabien/.rvm/gems/ruby-2.4.0/gems/therubyracer-0.12.2/lib/v8/conversion.rb:21:in `<top (required)>'
@lautis

This comment has been minimized.

Show comment
Hide comment
@lautis

lautis Dec 26, 2016

Owner

Thanks for the trace @Apokly. It seems that The Ruby Racer does not yet work with Ruby 2.4, but the fix is already merged: cowboyd/therubyracer@f2ccbad

Owner

lautis commented Dec 26, 2016

Thanks for the trace @Apokly. It seems that The Ruby Racer does not yet work with Ruby 2.4, but the fix is already merged: cowboyd/therubyracer@f2ccbad

@lautis lautis changed the title from Uglifier doesn't load with Ruby 2.4.0 to Uglifier doesn't load with Ruby 2.4.0 using The Ruby Racer JS runtime Dec 26, 2016

@ignisf

This comment has been minimized.

Show comment
Hide comment
@ignisf

ignisf Jan 7, 2017

Hello,

therubyracer 0.12.3 was released to rubygems with Ruby 2.4 support. (cowboyd/therubyracer#430)

ignisf commented Jan 7, 2017

Hello,

therubyracer 0.12.3 was released to rubygems with Ruby 2.4 support. (cowboyd/therubyracer#430)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment