Allow usage of non-allocating frame buffers#1095
Merged
Conversation
topi314
approved these changes
Aug 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a config option for toggling the use of non-allocating frame buffers.
In a high traffic environment, this can reduce pressure on the garbage collector by allowing each player to use a frame buffer specifically designed to reduce allocations by directly passing audio between byte buffers created at initialisation rather than when copying data outside of the player's control (i.e. user code). This should also have a positive effect by reducing CPU usage, thus increasing server performance.