Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Windows nodejs executable must be called node.exe #170

Closed
LukeOwncloud opened this Issue Apr 17, 2014 · 2 comments

Comments

Projects
None yet
3 participants

Try this:

crashtest.js

console.log('crashtest');
require('sync');
console.log('Everything fine.');

node.exe crashtest.js
Output:

crashtest
Everything fine.

copy node.exe node-x86.exe
node-x86.exe crashtest.js
Output:

crashtest

I found the problem is on line 17 in fibers.js which includes fiber via:
module.exports = require(modPath).Fiber;

modPath is something like: c:\myProject\node_modules\sync\node_modules\fibers\bin\win32-ia32-v8-3.14\fibers

This file contains the string "node.exe". Cannot find it in the source code, though.

I think this should be fixed or at least introduce a check for the expected file name ("node.exe").

@LukeOwncloud LukeOwncloud changed the title from Windows node executable must be called node.exe to Windows nodejs executable must be called node.exe Apr 17, 2014

Contributor

fresheneesz commented Apr 24, 2014

Can you distill this down to a minimal repro? Also please add what system you're using, what node version, and any other relevant information.

Owner

laverdet commented Dec 18, 2014

I have a sneaking suspicion this is just a deficiency with the way binary modules are handled on Windows. Try another binary module and you might run into similar problems

@laverdet laverdet closed this Dec 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment