Broken again with node 0.11.13 #173

Closed
bjouhier opened this Issue May 7, 2014 · 6 comments

4 participants

@bjouhier

@laverdet V8 API keeps changing 😢

I managed to make it work in my fork with the following changes (very dirty): bjouhier@4bd0276

@billmark

Would it make sense to use NAN (https://github.com/rvagg/nan) to isolate from the churn? I don't know what the performance impact would be though.

@shakefu

Hit this too. :(

@bjouhier

FWIW, I got my fork working in the node 0.12 branch.

API did not change this time but the auto discovery of floor_thread_key broke. Problem is that the isolate slot contains 0! So I hardcoded the offset. This is more fragile because it will break if fibers is loaded after another plugin that allocates TLS slots.

See bjouhier@bd12cc5

@laverdet
Owner

Sounds icky. I'm holding off on mucking around too much with fibers until the core team announces a v0.12 rc

@bjouhier

One solution would be to call the Isolate::isolate_key() internal method.

I know it's bad but I did include some internal headers in one of my plugins (galaxy-stack) and it actually works pretty well. Ironically internal code seems to survive V8 upgrades better than code based on the public API 👎

@Paxa Paxa referenced this issue in nwjs/nw.js Oct 6, 2014
Closed

node-webkit with fibers #533

@laverdet
Owner

Fixed in f5c85ba and 6e18f23

@laverdet laverdet closed this Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment