-
Notifications
You must be signed in to change notification settings - Fork 149
[Docs] Add Guidelines for External Media and Video Hosting #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wyllie Fang <wylliefang@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zihanKuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Recommended Approach (Page Bundling):** | ||
| ```markdown | ||
| // Directory structure | ||
| content/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since a detailed structural tree has already been provided, a brief textual explanation here will suffice.
| ### How to Add a Video | ||
| ```mermaid | ||
| graph LR | ||
| A[Add Video] --> B{Size >50MB?} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **Cloudflare Stream** (Paid, enterprise-grade) | ||
| - **Vimeo** (Paid, professional features) | ||
|
|
||
| #### Migration Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to mention "migration" here. This guide is for first-time learning path creation, and we no longer recommend using the static folder. Therefore, simply omit any reference to the usestatic method.
| D --> F[Local Reference] | ||
| ``` | ||
|
|
||
| #### Best Practices for Video Storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly introduce the two methods here, marking one as (Recommended).
As for "best practices," you can include them at the end, alongside your "Critical Considerations," changing that heading to "Best Practices."
Signed-off-by: Wyllie Fang <wylliefang@gmail.com>
|
Update:
|
zihanKuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Notes for Reviewers
This PR fixes #715
Signed commits