Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #65: added table sorting adjusted font colors on landscape page #209

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@Silvyre
Copy link
Contributor

Silvyre commented Oct 10, 2019

Resolves #65:

  • By default, all three tables on the Landscape Page are sorted by descending alphabetical order on their leftmost column.
  • Clicking on a column name on one of the aforementioned tables causes the table to be sorted by that column (toggling between ascending and descending order).
  • The orange font color styling for links on the Landscape Page was removed, leaving the inherited blue font color.
@Silvyre Silvyre requested a review from leecalcote Oct 10, 2019
@leecalcote

This comment has been minimized.

Copy link
Member

leecalcote commented Oct 10, 2019

@Silvyre strikes again! :)

Copy link
Member

leecalcote left a comment

@Silvyre given the update from orange to blue hyperlink color on the landscape, we'd do well to restyle the links on https://layer5.io/workshops/. These same workshops are currently shown on the root index page as well.

@Silvyre

This comment has been minimized.

Copy link
Contributor Author

Silvyre commented Oct 10, 2019

Sure, I can do that!

Copy link
Member

leecalcote left a comment

LGTM. Thank you, @Silvyre!

@leecalcote leecalcote merged commit 4a370a3 into layer5io:master Oct 11, 2019
@leecalcote

This comment has been minimized.

Copy link
Member

leecalcote commented Oct 11, 2019

Oh, @Silvyre, a note regarding the first section of the landscape that contains five categories of technologies - the list of projects within those categories is alphabetical when viewed in a mobile-size browser, but are listed left-to-right when viewed in a desktop browser. The lists in these categories are easier to read when listed alphabetically from top-down. We may want to open a separate issue to ensure they are listed top-down, in each column when in a wide browser

@Silvyre

This comment has been minimized.

Copy link
Contributor Author

Silvyre commented Oct 11, 2019

Agreed, this behaviour should be adjusted, and via a new issue.

@Silvyre Silvyre deleted the Silvyre:issue-65 branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.