fix GitHub logo for dark mode #3791
Conversation
Signed-off-by: Nikhil Barik <36399086+nerdynikhil@users.noreply.github.com>
Signed-off-by: Nikhil Barik <36399086+nerdynikhil@users.noreply.github.com>
nerdynikhil
force-pushed
the
fix_3785
branch
from
72c8e18
to
5940c06
Compare
|
🚀 Preview for commit 5940c06 at: https://63f3746aeeaea55a548d23b4--layer5.netlify.app |
There was a problem hiding this comment.
@nerdynikhil You are right, the logo should be the same in both modes. Please change it as per the needs.
Should I resize it myself and upload it to assets so that it can be used? @UtkarshMishra12 |
@nerdynikhil Yes, you can. Or you can look into the assets for the image, maybe you'll be able to find one. |
|
Yes, I tried |
|
@nerdynikhil Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :) |
There was a problem hiding this comment.
Hey @nerdynikhil, resizing the assets would work. Also the MeshMap icon is a bit larger than the others because of it's different aspect ratio. Let's have it consistent as well, height: 48px, width: 48px.
Also let's try to keep the PR free from indentation changes. It just makes reviewers life a little easy 😀
|
Hello @GaganpreetKaurKalsi , I hope this message finds you well. I am writing to express my interest in contributing to the project and fixing issue #3791, which is related to fixing the GitHub logo for dark mode. I have experience working with CSS and web design, and I believe I can help address this issue. I have also read through the project's contribution guidelines and code of conduct, and I'm committed to following the established best practices and protocols. Would it be possible to assign this issue to me? I would be happy to collaborate with other team members and ensure that the logo is properly updated for dark mode users. Thank you for your consideration, and I look forward to contributing to the project. Best regards, |
|
Hey reviewers, I started a thread a Slack on this. Kindly take a look at it and advice. https://layer5io.slack.com/archives/C015QJKUMPU/p1677522842958589 |
|
I’m guessing the page http://localhost:8000/cloud-native-management/meshery/operating-service-meshes itself has some CSS issue which is causing SVGs to appear larger in dark mode. For instance look the Likewise, the existing Github logo (svg) in assets would suffice without any resizing if we fix this, but we probably need some minor CSS change.
|
|
@nerdynikhil Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :) |
|
@hirentimbadiya is working on this. |
Description
This PR fixes #3785
Notes for Reviewers
Before
After
I used only the existing assets. However, the light logo seems to be a bit larger. Need advice on this.
Signed commits