From 95a86f99716353360e168f6a044325a0a3d538e2 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Fri, 17 Apr 2015 21:43:29 +0200 Subject: [PATCH] Fail build on linting error Also bump all deps --- .jscsrc | 1 + .jshintrc | 3 ++- index.js | 1 - package.json | 16 ++++++++-------- test/main.js | 2 +- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/.jscsrc b/.jscsrc index 9ac20df..453744f 100644 --- a/.jscsrc +++ b/.jscsrc @@ -5,6 +5,7 @@ }, "disallowQuotedKeysInObjects": true, "disallowPaddingNewlinesInBlocks": true, + "disallowNewlineBeforeBlockStatements": true, "disallowSpacesInFunctionExpression": { "beforeOpeningRoundBrace": true }, diff --git a/.jshintrc b/.jshintrc index e10d992..5c30aae 100644 --- a/.jshintrc +++ b/.jshintrc @@ -1,5 +1,6 @@ { "node": true, "latedef": true, - "undef": true + "undef": true, + "unused": true } diff --git a/index.js b/index.js index e4e0b2e..56c2766 100644 --- a/index.js +++ b/index.js @@ -6,7 +6,6 @@ var gutil = require('gulp-util'); var c = gutil.colors; var error = gutil.PluginError; var es = require('event-stream'); -var fs = require('fs'); var csslint = require('csslint').CSSLint; var RcLoader = require('rcloader'); diff --git a/package.json b/package.json index 480a9ec..e8dfd24 100644 --- a/package.json +++ b/package.json @@ -8,22 +8,22 @@ ], "dependencies": { "csslint": "^0.10.0", - "event-stream": "^3.3.0", + "event-stream": "^3.3.1", "gulp-util": "^3.0.4", "rcloader": "^0.1.4" }, "devDependencies": { "coveralls": "^2.11.2", - "istanbul": "^0.3.13", - "jscs": "^1.12.0", - "jshint": "^2.6.3", - "mocha": "^2.2.4", - "rimraf": "^2.3.2", - "should": "^5.2.0" + "istanbul": "^0.3.14", + "jscs": "^1.13.1", + "jshint": "^2.7.0", + "mocha": "^2.2.5", + "rimraf": "^2.3.4", + "should": "^6.0.3" }, "scripts": { "clean": "rimraf coverage/", - "lint": "jscs index.js test/ & jshint index.js test/", + "lint": "jscs index.js test/ && jshint index.js test/", "pretest": "npm run lint", "test": "mocha", "precover": "npm run lint && npm run clean", diff --git a/test/main.js b/test/main.js index bb0ec44..803d595 100644 --- a/test/main.js +++ b/test/main.js @@ -92,7 +92,7 @@ describe('gulp-csslint', function() { var file2 = getFile('fixtures/missingPrefixes.css'); var stream = cssLintPlugin(); - stream.on('data', function(newFile) { + stream.on('data', function() { ++a; });