Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use through2 instead of event-stream #38

Merged
merged 3 commits into from Feb 18, 2015

Conversation

Projects
None yet
2 participants
@shinnn
Copy link
Contributor

commented Jan 28, 2015

@shinnn shinnn changed the title Through2 Use through2 instead of event-stream Jan 28, 2015

@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2015

@lazd What do you think?

@lazd

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2015

@shinnn I just took a look at the code and this looks like a huge improvement. Merging!

lazd added a commit that referenced this pull request Feb 18, 2015

Merge pull request #38 from shinnn/through2
Use through2 instead of event-stream

@lazd lazd merged commit b495331 into lazd:master Feb 18, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2015

@lazd Thanks! Could you release a new version?

@shinnn shinnn deleted the shinnn:through2 branch Feb 18, 2015

@lazd

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2015

I updated dependencies then changed package.json to use exact dependency versions (no ^ as we've been bitten before by bad updates to deps) and released as gulp-replace@0.5.3.

Thanks for the contribution!

@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2015

@lazd

I know why you lock the dependency versions in this project (#34). I agree to lock the version of istextorbinary.

However, that is the very rare case, I think. At least the authors of replacestream and through2 are both awesome programmers AFAIK, so we can rely on the versioning of these two projects.

How about using ^ for replacestream and through2?

@lazd

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2015

@shinnn I totally understand your point of view and agree that the folks behind those libraries are rockstars, but mistakes can still happen.

Given that gulp-replace may be used in thousands of build processes, I'd rather be certain it'll continue to work if left untouched than potentially pick up fixes to dependent libraries. Of course, I'll have to more closely monitor dependency versions, but I think the stability of locking dependency versions outweighs the burden of monitoring whether an update is needed.

@shinnn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2015

@lazd 👍 Also correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.