From e96ff436e00e63abfb49d654a8f00d9a43a31fd3 Mon Sep 17 00:00:00 2001 From: Christopher Albert Date: Sun, 24 Aug 2025 05:51:33 +0200 Subject: [PATCH 1/3] plan: add documentation bug issues to BACKLOG.md --- BACKLOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BACKLOG.md b/BACKLOG.md index af23e832..0341af5e 100644 --- a/BACKLOG.md +++ b/BACKLOG.md @@ -4,7 +4,7 @@ - [ ] #224: PDF files not deployed to GitHub Pages (404 errors) ## DOING (Current Work) -- [x] #223: ASCII backend generates empty plots (only frames/borders) (branch: fix/ascii-empty-plots-223) ## DONE (Completed) +- [x] #223: ASCII backend generates empty plots (only frames/borders) - [x] #220: Fix ASCII backend generating PDF binary content instead of text output \ No newline at end of file From 3543279cfd34d023dc3e83bd217932dbd38c81f7 Mon Sep 17 00:00:00 2001 From: Christopher Albert Date: Sun, 24 Aug 2025 07:12:54 +0200 Subject: [PATCH 2/3] update: move issue #224 from TODO to DOING --- BACKLOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BACKLOG.md b/BACKLOG.md index 0341af5e..46a64e0a 100644 --- a/BACKLOG.md +++ b/BACKLOG.md @@ -1,9 +1,9 @@ # Development Backlog ## TODO (Ordered by Priority) -- [ ] #224: PDF files not deployed to GitHub Pages (404 errors) ## DOING (Current Work) +- [x] #224: PDF files not deployed to GitHub Pages (404 errors) (branch: fix/pdf-deployment-224) ## DONE (Completed) - [x] #223: ASCII backend generates empty plots (only frames/borders) From 29b3960bdd7b8a3666538e791dffcfe943c37b4b Mon Sep 17 00:00:00 2001 From: Christopher Albert Date: Sun, 24 Aug 2025 07:19:43 +0200 Subject: [PATCH 3/3] fix: move media file copying after FORD generation in make doc FORD was wiping the build/doc directory clean before generating documentation, removing any media files copied beforehand. This caused PDF files to be missing from GitHub Pages deployment, resulting in 404 errors. Fixed by reordering the make doc target to: 1. Run FORD first to generate documentation structure 2. Copy media files after FORD completes This ensures media files are preserved in the final build/doc directory that gets deployed to GitHub Pages. fixes #224 --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 248debd5..07b72aac 100644 --- a/Makefile +++ b/Makefile @@ -90,7 +90,9 @@ run-release: # Build documentation with FORD doc: - # Copy example media files to doc build directory BEFORE running FORD for proper linking + # Run FORD first to generate documentation structure + ford README.md + # Copy example media files to doc build directory AFTER running FORD mkdir -p build/doc/media/examples # Copy from doc/media if it exists (GitHub Actions workflow populates this) if [ -d doc/media/examples ]; then cp -r doc/media/examples/* build/doc/media/examples/ 2>/dev/null || true; fi @@ -105,8 +107,6 @@ doc: cp "$$dir"*.mp4 "build/doc/media/examples/$$example_name/" 2>/dev/null || true; \ fi; \ done - # Now run FORD after media files are in place - ford README.md # Generate coverage report coverage: