Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird bug with to-do list #4

Open
PGmajev opened this issue Dec 14, 2019 · 1 comment
Open

Weird bug with to-do list #4

PGmajev opened this issue Dec 14, 2019 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@PGmajev
Copy link

PGmajev commented Dec 14, 2019

I do not know whether this falls into the responsibility of this skill, but here it goes:

So when I tell Mycroft to create a list called "to-do" it will create a list called "to do" but when I then tell it to list things on my list "to-do" it will actually search for a list called "to-do" and not "to do". Am I the only one experiencing this?

@lb803
Copy link
Owner

lb803 commented Apr 27, 2021

Hi @PGmajev
Apologies for the late response.

You are right, I experience the same issue. Here is my log where I create the "to do" list and then I enquire about what elements are on the list:

==> /var/log/mycroft/voice.log <==
2021-04-27 09:49:46.489 | INFO     |  3345 | __main__:handle_wakeword:67 | Wakeword Detected: christopher
2021-04-27 09:49:46.997 | INFO     |  3345 | __main__:handle_record_begin:37 | Begin Recording...
2021-04-27 09:49:49.970 | INFO     |  3345 | __main__:handle_record_end:45 | End Recording...

==> /var/log/mycroft/audio.log <==
2021-04-27 09:49:51.734 | INFO     |  3342 | mycroft.audio.speech:mute_and_speak:127 | Speak: Your new list to do has been added.

==> /var/log/mycroft/voice.log <==
2021-04-27 09:49:51.488 | INFO     |  3345 | __main__:handle_utterance:72 | Utterance: ['create a new list called to do']

==> /var/log/mycroft/skills.log <==
2021-04-27 09:49:52.375 | INFO     |  3339 | mycroft.skills.skill_loader:reload:179 | ATTEMPTING TO RELOAD SKILL: list-manager.lb803
2021-04-27 09:49:52.392 | INFO     |  3339 | mycroft.skills.skill_loader:_execute_instance_shutdown:217 | Skill list-manager.lb803 shut down successfully
2021-04-27 09:49:52.399 | INFO     |  3339 | mycroft.skills.settings:get_local_settings:80 | /root/.config/mycroft/skills/list-manager.lb803/settings.json
2021-04-27 09:49:52.432 | INFO     |  3339 | mycroft.skills.skill_loader:_communicate_load_status:344 | Skill list-manager.lb803 loaded successfully
2021-04-27 09:49:52.433 | INFO     |  3339 | mycroft.skills.skill_manager:put:80 | Updating settings meta during runtime...
2021-04-27 09:49:52.512 | INFO     |  3339 | msm.mycroft_skills_manager | invalidating skills cache
2021-04-27 09:49:52.513 | INFO     |  3339 | msm.mycroft_skills_manager | building SkillEntry objects for all skills
2021-04-27 09:49:55.454 | INFO     |  3339 | mycroft.skills.skill_manager:send:64 | New Settings meta to upload.

==> /var/log/mycroft/voice.log <==
2021-04-27 09:50:05.950 | INFO     |  3345 | __main__:handle_wakeword:67 | Wakeword Detected: christopher
2021-04-27 09:50:06.446 | INFO     |  3345 | __main__:handle_record_begin:37 | Begin Recording...
2021-04-27 09:50:08.778 | INFO     |  3345 | __main__:handle_record_end:45 | End Recording...

==> /var/log/mycroft/audio.log <==
2021-04-27 09:50:10.582 | INFO     |  3342 | mycroft.audio.speech:mute_and_speak:127 | Speak: I couldn't find to-do among your lists.

==> /var/log/mycroft/voice.log <==
2021-04-27 09:50:10.318 | INFO     |  3345 | __main__:handle_utterance:72 | Utterance: ["what's on my to-do list"]

This is partially a Mycroft-related issue, as the words "to do" are at first recognised as "to do" and later as "to-do". At present, the skill is very rigid and requires exact matches for list and element names to be processed.

What I could do is adopt a more relaxed way to identify list and element names, not sure the best way to archive this would be either:

  • Adopting a fuzzy string matching python library;
  • Change the DB module with a different one which provides this functionality.

I am open to comments and suggestions.

@lb803 lb803 added bug Something isn't working help wanted Extra attention is needed labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants