--enable-thread-safe-observer-pattern works with --enable-std-pointers #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lballabio
reviewed
Oct 1, 2018
ql/patterns/observable.hpp
Outdated
| namespace ext { | ||
|
|
||
| #if defined(QL_USE_STD_SHARED_PTR) | ||
| using std::enable_shared_from_this; |
There was a problem hiding this comment.
I would move this (and the inclusion of <boost/enable_shared_from_this.hpp> above) to ql/shared_ptr.hpp where the other related classes are added to namespace ext.
lballabio
reviewed
Oct 3, 2018
ql/patterns/observable.hpp
Outdated
| @@ -264,14 +264,15 @@ namespace QuantLib { | |||
| #include <boost/enable_shared_from_this.hpp> | |||
There was a problem hiding this comment.
I think this should go in ql/shared_ptr.hpp, too? (If the using statement there works using the boost classes, instead, that means we can remove this here.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #546