Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop writing Java code in Python! #107

Closed
kamikaze opened this issue Mar 26, 2018 · 1 comment
Closed

stop writing Java code in Python! #107

kamikaze opened this issue Mar 26, 2018 · 1 comment

Comments

@kamikaze
Copy link

Please follow PEP-8, don't write camel case method names. Also use the same signature for Date constructor as in stdlib!

@lballabio
Copy link
Owner

I'm aware of PEP-8, and I sympathize. The camel-case names do stick out in Python.

However, the names come from the underlying C++ library, for which camel case is idiomatic, so those are not going to change. It would be possible to rename the methods when wrapping the library for Python (while leaving them unchanged when wrapping for other languages), but I see two objections.

  • The library has been around for 17 years now, and a number of users have written code that depend on it. Renaming the methods would break their code. I'm not willing to do that.
  • Even if we were willing to break things, this project is run on volunteer time (and not a lot of it), and I feel that the time required to make and maintain the changes would be better spent on other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants