Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user or prompt for default when other lbry:// schema apps installed #300

Closed
10 tasks
LavRadis opened this issue Sep 17, 2018 · 4 comments
Closed
10 tasks
Labels
priority: low Work should be done but can stay in the backlog for now

Comments

@LavRadis
Copy link

LavRadis commented Sep 17, 2018

The Issue

"Magic link" confirmation link makes Android offer to open LBRY app OR Coinomi (since the also registered for lbry://). The page needs a better how-to explanation for the new user to reduce confusion and number of people who will choose to open with Coinomi.

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
@LavRadis LavRadis changed the title "Magic link" page needs better how-to for Andorid "Magic link" page needs better how-to for Android Sep 17, 2018
@tzarebczan
Copy link
Contributor

I originally thought this note might be better on the Android app, but agree that it makes more sense ont he verification page. Will move this over to lbry.io.

@tzarebczan
Copy link
Contributor

Issue moved to lbryio/lbry.io #765 via ZenHub

@tzarebczan tzarebczan changed the title "Magic link" page needs better how-to for Android Notify user or prompt for default when other lbry:// schema apps installed Sep 17, 2018
@tzarebczan
Copy link
Contributor

tzarebczan commented Sep 17, 2018

Reopening per lbryio/lbry.com#765 (comment)

Maybe we can prompt users to make the LBRY Android app the default for lbry:// schema links. If not, we should notify them they need to choose LBRY when going through verification / lbry:// links.

@tzarebczan tzarebczan reopened this Sep 17, 2018
@alyssaoc alyssaoc added the priority: low Work should be done but can stay in the backlog for now label Sep 17, 2018
@akinwale
Copy link
Contributor

This is handled at the device OS level. The user is prompted to select the default app for the corresponding schema links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Work should be done but can stay in the backlog for now
Projects
None yet
Development

No branches or pull requests

4 participants