New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow dark mode with automatic night mode enabled #1005

Closed
tzarebczan opened this Issue Feb 8, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@tzarebczan
Member

tzarebczan commented Feb 8, 2018

The Issue

If you enable automatic night mode, the theme selection should not allow the dark theme to be chosen as it overrides the setting. Not sure about disabling the theme selection completely - right now it makes sense because there is only 1 option, but in the future when we have more, a user may want theme X and have night mode enabled.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Feb 8, 2018

Member

Probably better to disable the night mode setting once the dark theme has been selected than to disable the theme if night mode is selected.

Member

kauffj commented Feb 8, 2018

Probably better to disable the night mode setting once the dark theme has been selected than to disable the theme if night mode is selected.

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Feb 8, 2018

Member

Fixed in #1006

Member

seanyesmunt commented Feb 8, 2018

Fixed in #1006

@seanyesmunt seanyesmunt closed this Feb 8, 2018

@lbry-bot lbry-bot removed the needs: triage label Feb 8, 2018

@seanyesmunt seanyesmunt reopened this Feb 8, 2018

@seanyesmunt seanyesmunt self-assigned this Feb 12, 2018

@lbry-bot lbry-bot removed the needs: triage label Feb 26, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 2, 2018

Member

Going to re-open this because you can select automatic dark mode while dark is selected, which forces the app to stay in dark mode.

Member

tzarebczan commented May 2, 2018

Going to re-open this because you can select automatic dark mode while dark is selected, which forces the app to stay in dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment