Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Error when clicking LBRY URLs when app is closed on macOS #1119
Works fine if the app is open.
Steps to reproduce
I'm taking a look at how this process was refactored. So far this is what I can tell:
Looks like the handler in isSecondInstance allows it to function properly on Windows. The Mac protocol handler fails if the app is closed (this ticket). Opened a separate issue for Linux (#1120) but I can see why it wouldn't work based on the current code - uri is never set (easy fix in isSecondInstance but then run into the same issue as this ticket).
We should have a single function handle all URL opening which would handle cases of the app being open/closed and the Windows regex.