New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when clicking LBRY URLs when app is closed on macOS #1119

Closed
tzarebczan opened this Issue Mar 17, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented Mar 17, 2018

The Issue

If LBRY is closed and a LBRY hyperlink is clicked, the app opens but errors out on Mac. See below
screen_shot_2018-03-06_at_10 47 30_am

A similar issue was fixed here:
mathiasvr/webtorrent-desktop@eeda7c1
and here:
keeweb/keeweb@a29688c

Works fine if the app is open.

Steps to reproduce

  1. Make sure LBRY is closed
  2. Click LBRY URL from email or: https://open/lbry.io/test
  3. Error

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Mar 18, 2018

Member

On the latest RC, the error is which is happening because the window isn't rendered before it's called.
rc mac

I'm taking a look at how this process was refactored. So far this is what I can tell:

  1. there's a URL handler in index.js which says it's only for the mac and another piece of code in isSecondInstance
  2. The other URL calls are in createWindow.js but they would only work on Windows since deepLinkingURI is only populated for win32. This is probably what allows for links when LBRY is closed.

Looks like the handler in isSecondInstance allows it to function properly on Windows. The Mac protocol handler fails if the app is closed (this ticket). Opened a separate issue for Linux (#1120) but I can see why it wouldn't work based on the current code - uri is never set (easy fix in isSecondInstance but then run into the same issue as this ticket).

We should have a single function handle all URL opening which would handle cases of the app being open/closed and the Windows regex.

Member

tzarebczan commented Mar 18, 2018

On the latest RC, the error is which is happening because the window isn't rendered before it's called.
rc mac

I'm taking a look at how this process was refactored. So far this is what I can tell:

  1. there's a URL handler in index.js which says it's only for the mac and another piece of code in isSecondInstance
  2. The other URL calls are in createWindow.js but they would only work on Windows since deepLinkingURI is only populated for win32. This is probably what allows for links when LBRY is closed.

Looks like the handler in isSecondInstance allows it to function properly on Windows. The Mac protocol handler fails if the app is closed (this ticket). Opened a separate issue for Linux (#1120) but I can see why it wouldn't work based on the current code - uri is never set (easy fix in isSecondInstance but then run into the same issue as this ticket).

We should have a single function handle all URL opening which would handle cases of the app being open/closed and the Windows regex.

@IGassmann IGassmann self-assigned this Mar 19, 2018

@IGassmann IGassmann changed the title from MAC: error when clicking LBRY URL when app is closed to Error when clicking LBRY URLs when app is closed on macOS Mar 20, 2018

@IGassmann IGassmann closed this in e6e8218 Mar 20, 2018

@lbry-bot lbry-bot removed the needs: triage label Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment