New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't allow to open multiple export and choose file dialogs #1175

Closed
namujan78 opened this Issue Mar 24, 2018 · 10 comments

Comments

Projects
None yet
5 participants
@namujan78

namujan78 commented Mar 24, 2018

The Issue

User can open many "Choose file" windows to select files to publish
Same for "Choose directory" in Settings page
Same for "EXPORT" in History page (transaction history) and Overview page

Steps to reproduce

  1. Click on "PUBLISH" button
  2. Click on "CHOOSE FILE" button ==> "Choose file" window will display
  3. Click on "CHOOSE FILE" button again ==> another "Choose file" window will display
  4. Repeat step 3 many time ==> many "Choose file" windows will display

Expected behaviour

User should open only one "Choose file" windows, and it will be in top selection, User cannot focus on the Publish page after selected file success or close the "Choose file" windows

Actual behaviour

User can open many "Choose file" windows by clicking on "Choose file" button.
Same for "Choose directory" in Settings page
Same for "EXPORT" in History page (transaction history)

System Configuration

  • LBRY Daemon version: 0.19.1
  • LBRY App version: 0.21.2
  • LBRY Installation ID: N/A
  • Operating system: Windows (Windows-10-10.0.16299)
  • Wallet (lbryum): 3.2.0

Anything Else

Same for "Choose directory" in Settings page
Same for "EXPORT" in History page (transaction history) and Overview page

Screenshots

N/A

@namujan78 namujan78 changed the title from Shouldn't allow open/browse multiple "CHOOSE FILE" windows in PUBLISH page to Shouldn't allow open/browse multiple "CHOOSE FILE" windows in PUBLISH page and other windows Mar 24, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Mar 26, 2018

Member

@namujan78 thanks for the detailed write-up! I've sent you a tip on Discord :)

Member

tzarebczan commented Mar 26, 2018

@namujan78 thanks for the detailed write-up! I've sent you a tip on Discord :)

@btzr-io btzr-io self-assigned this Jun 21, 2018

@btzr-io btzr-io changed the title from Shouldn't allow open/browse multiple "CHOOSE FILE" windows in PUBLISH page and other windows to Shouldn't allow to open multiple export and choose file dialogs Jun 21, 2018

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Jun 26, 2018

Collaborator

Fixed and merged in master.

Collaborator

btzr-io commented Jun 26, 2018

Fixed and merged in master.

@tzarebczan tzarebczan closed this Jun 26, 2018

@namujan78

This comment has been minimized.

Show comment
Hide comment
@namujan78

namujan78 Jul 14, 2018

@tzarebczan This issue still happens when you quickly click multiple times on CHOOSE FILE after the PUBLISH screen appeared.
CC @btzr-io
image

namujan78 commented Jul 14, 2018

@tzarebczan This issue still happens when you quickly click multiple times on CHOOSE FILE after the PUBLISH screen appeared.
CC @btzr-io
image

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Jul 14, 2018

Collaborator

I can confirm this is working on linux, not sure about macOS,
Maybe this is a windows-bug ?

Collaborator

btzr-io commented Jul 14, 2018

I can confirm this is working on linux, not sure about macOS,
Maybe this is a windows-bug ?

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jul 14, 2018

Member

He's clicking it really quickly... I'll try on windows. This is an edge case though, someone won't click like that :)

Member

tzarebczan commented Jul 14, 2018

He's clicking it really quickly... I'll try on windows. This is an edge case though, someone won't click like that :)

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Jul 14, 2018

Collaborator

Clicking really quick freezes the window:
electron/electron#11323

Collaborator

btzr-io commented Jul 14, 2018

Clicking really quick freezes the window:
electron/electron#11323

@namujan78

This comment has been minimized.

Show comment
Hide comment
@namujan78

namujan78 Jul 15, 2018

It’s not freeze, but the app become slow responsive in some seconds, then back to normal after open multiple choose file windows.

namujan78 commented Jul 15, 2018

It’s not freeze, but the app become slow responsive in some seconds, then back to normal after open multiple choose file windows.

@namujan78

This comment has been minimized.

Show comment
Hide comment
@namujan78

namujan78 Jul 15, 2018

One more thing, it happen only for first time you go to Publish app.
Next time it doesn’t happen. Maybe the app load complete all components successfull.

namujan78 commented Jul 15, 2018

One more thing, it happen only for first time you go to Publish app.
Next time it doesn’t happen. Maybe the app load complete all components successfull.

@seanyesmunt

This comment has been minimized.

Show comment
Hide comment
@seanyesmunt

seanyesmunt Jul 16, 2018

Member

It doesn't happen on macOS.

Member

seanyesmunt commented Jul 16, 2018

It doesn't happen on macOS.

@namujan78

This comment has been minimized.

Show comment
Hide comment
@namujan78

namujan78 Sep 15, 2018

@tzarebczan How about the status of this issue?
I think we should change the Closed to open/in progress if you still want fix it.
If not we just ignore this case.

Procedure of this case is:

  • Click on "PUBLISH" button then quickly multi click on "Choose file" when you can see "Choose file" button ==> Multi windows will appear

I don't have macOS so that I cannot confirm it happen or not on macOS. As well as Ubuntu.

CC @btzr-io @seanyesmunt

namujan78 commented Sep 15, 2018

@tzarebczan How about the status of this issue?
I think we should change the Closed to open/in progress if you still want fix it.
If not we just ignore this case.

Procedure of this case is:

  • Click on "PUBLISH" button then quickly multi click on "Choose file" when you can see "Choose file" button ==> Multi windows will appear

I don't have macOS so that I cannot confirm it happen or not on macOS. As well as Ubuntu.

CC @btzr-io @seanyesmunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment