New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-side changes to allow reward changes without app-side changes #1329

Closed
kauffj opened this Issue Apr 16, 2018 · 4 comments

Comments

@kauffj
Member

kauffj commented Apr 16, 2018

  1. Display the rewards in the order returned by api.lbry.io rather than the app-coded order.
  2. Look for a reward property on an individual reward called reward_notification that is displayed to the user when they earn a reward.
  3. Have a fall-back notification when a reward_notificaiton isn't provided (e.g. "You earned a %s LBC reward).
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Apr 30, 2018

Member

The API side changes can be seen here: lbryio/internal-apis#294

The API now returns the description and notification text:

"success": true,
  "error": null,
  "data": [
    {
      "id": 73950,
      "reward_type": "new_user",
      "reward_amount": 3,
      "transaction_id": "ed633e1d1000dd748948de95dc60bfaaa3f7defd49f39ad44c2ceffc769ee615",
      "created_at": "2017-07-25T04:43:21Z",
      "updated_at": "2017-12-23T06:21:43Z",
      "reward_version": null,
      "reward_title": "Your First Nickel",
      "reward_description": "A welcome bonus and thank you for your contribution to content freedom.",
      "reward_notification": "You earned 3 LBC new user reward."
    },
    {
      "id": 77407,
      "reward_type": "first_stream",
      "reward_amount": 2,
      "transaction_id": "ebe63acdf81c604ca6c1cb8de0fd0611064aa483efcb38c506df05c66954e381",
      "created_at": "2017-07-25T18:53:41Z",
      "updated_at": "2017-12-23T06:21:43Z",
      "reward_version": null,
      "reward_title": "Go for a Stream",
      "reward_description": "Just press play on something. Anything at all. Yep, even that one. Everybody's doing it.",
      "reward_notification": "You earned 2 LBC for streaming your first video."
Member

tzarebczan commented Apr 30, 2018

The API side changes can be seen here: lbryio/internal-apis#294

The API now returns the description and notification text:

"success": true,
  "error": null,
  "data": [
    {
      "id": 73950,
      "reward_type": "new_user",
      "reward_amount": 3,
      "transaction_id": "ed633e1d1000dd748948de95dc60bfaaa3f7defd49f39ad44c2ceffc769ee615",
      "created_at": "2017-07-25T04:43:21Z",
      "updated_at": "2017-12-23T06:21:43Z",
      "reward_version": null,
      "reward_title": "Your First Nickel",
      "reward_description": "A welcome bonus and thank you for your contribution to content freedom.",
      "reward_notification": "You earned 3 LBC new user reward."
    },
    {
      "id": 77407,
      "reward_type": "first_stream",
      "reward_amount": 2,
      "transaction_id": "ebe63acdf81c604ca6c1cb8de0fd0611064aa483efcb38c506df05c66954e381",
      "created_at": "2017-07-25T18:53:41Z",
      "updated_at": "2017-12-23T06:21:43Z",
      "reward_version": null,
      "reward_title": "Go for a Stream",
      "reward_description": "Just press play on something. Anything at all. Yep, even that one. Everybody's doing it.",
      "reward_notification": "You earned 2 LBC for streaming your first video."
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 14, 2018

Member

@daovist this could be another one to take a look at. Epic is here: #1328

Member

tzarebczan commented May 14, 2018

@daovist this could be another one to take a look at. Epic is here: #1328

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj May 15, 2018

Member

@daovist this is a strong candidate to knock out. Likely only a few hours work.

@tzarebczan I'm tagging this release blocker as I don't want to have to wait another month to be able to create new rewards without waiting on app releases.

Member

kauffj commented May 15, 2018

@daovist this is a strong candidate to knock out. Likely only a few hours work.

@tzarebczan I'm tagging this release blocker as I don't want to have to wait another month to be able to create new rewards without waiting on app releases.

@daovist

This comment has been minimized.

Show comment
Hide comment
@daovist

daovist May 16, 2018

Collaborator

@kauffj I'm on it first thing tomorrow

Collaborator

daovist commented May 16, 2018

@kauffj I'm on it first thing tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment