New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can type in unfocused fields while publishing without selecting file #1456

Closed
tzarebczan opened this Issue May 9, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@tzarebczan
Member

tzarebczan commented May 9, 2018

The Issue

When going to the publish screen, the select file area is in focus and the rest of the screen is grayed out, but you can still go into most of the fields and type (blocked from Title/thumbnail, but rest work, even dropdowns). If we intend to force users to select a file first, we should not allow typing anywhere else on the publish form.

Steps to Reproduce

  1. Click publish, don't select a file
  2. Scroll down to description or claim name
  3. You can type

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj May 9, 2018

Member
Member

kauffj commented May 9, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 10, 2018

Member

@seanyesmunt another thing to consider is that we still rely on the Publish screen for the channel creation process, which is now even more hidden because you need to select a file first (what if I want to create a channel without publishing? )

Member

tzarebczan commented May 10, 2018

@seanyesmunt another thing to consider is that we still rely on the Publish screen for the channel creation process, which is now even more hidden because you need to select a file first (what if I want to create a channel without publishing? )

@tzarebczan tzarebczan changed the title from Can type in unfocused fileds while publishing without selecting file to Can type in unfocused fields while publishing without selecting file May 10, 2018

@btzr-io btzr-io self-assigned this Jun 20, 2018

btzr-io added a commit that referenced this issue Jun 21, 2018

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jun 21, 2018

Member

Fixed in: #1659

Member

tzarebczan commented Jun 21, 2018

Fixed in: #1659

@tzarebczan tzarebczan closed this Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment