Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation button resulting incorrect page designation #1502

Closed
ceoger opened this Issue May 23, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@ceoger
Copy link
Contributor

ceoger commented May 23, 2018

The Issue

back navigation button resulting incorrect page designation

Steps to Reproduce

  1. go to brightsunfilms channel
  2. click page 11
  3. click back button
  4. It shows page 1 but highlights page 11.

Expected Behaviour

Back should take you to previous page and highlight page number

Actual Behaviour

It shows page 1 but highlights page 11.
same for other pages, be on page 11, click page 10, click back and it takes you back to page 11 with pag 10 still highlighted

Suggested Solutions

Back should take you to previous page and highlight page number

System Configuration

  • LBRY Daemon version: 0.19.1
  • LBRY App version: 0.22.0-rc.8
  • LBRY Installation ID: 3cXLZiAWXwwJbv4fjhbXVgFtaBuUiFQM7afXmFYu5ss1chD1WCpxGUp8aW68gjeNRC
  • Operating system: Windows (Windows-10-10.0.16299)

Anything Else

https://cdn.discordapp.com/attachments/377895389992321064/447849109462843402/1.JPG
https://cdn.discordapp.com/attachments/377895389992321064/447849121521336320/2.JPG

Screenshots

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented May 23, 2018

Can confirm this is a bug pre-redesign as well.

@ceoger please upload those images directly into the ticket, otherwise the links may get taken down by Discord.

Thanks again for filing, sent you some LBC on Discord!

@ceoger

This comment has been minimized.

Copy link
Contributor Author

ceoger commented May 23, 2018

@tzarebczan there is no channel pages in the predesign... i double checked

@tiger5226

This comment has been minimized.

Copy link
Member

tiger5226 commented Jun 10, 2018

@tzarebczan this was fixed recently with another PR. I can't find it though. I tested and it appear to be working fine ( the back button ) in the redesign. Can you confirm?

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 10, 2018

@tiger5226 just tried it on 0.20rc10 and it still occurs.

@tiger5226 tiger5226 removed the area: search label Jun 10, 2018

@tiger5226

This comment has been minimized.

Copy link
Member

tiger5226 commented Jun 10, 2018

Ohh sorry wrong issue. The search page back button wasn't working and is now. This issue is different, my apologies.

@btzr-io btzr-io self-assigned this Jun 21, 2018

@btzr-io btzr-io changed the title back navigation button resulting incorrect page designation Navigation button resulting incorrect page designation Jun 21, 2018

@btzr-io

This comment has been minimized.

Copy link
Collaborator

btzr-io commented Jun 26, 2018

Fixed and merged in master.

@tzarebczan tzarebczan closed this Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.