New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lines not showing correctly after markdown changes #1504

Closed
tzarebczan opened this Issue May 23, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented May 23, 2018

The Issue

After we implemented the markdown changes, regular new lines are not showing properly because they are trying to use markdown syntax which requires 3 spaces at the end of a line, or 2 new lines. Is it easy just to default to new lines after each line break?

See: lbry://ScreenToGif12-50-45590#f8866c585e39d26f87039547e0c51b2614280eb0

The description field is:
"description": "no thumb\ntest2nd line",

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan May 29, 2018

Member

@btzr-io maybe there's a quick fix to this?

Also, just popped into my head but unrelated, we'll need to get the markdown preview function in publish to show a more accurate preview using our current markdown rules (or disable it completely).

Member

tzarebczan commented May 29, 2018

@btzr-io maybe there's a quick fix to this?

Also, just popped into my head but unrelated, we'll need to get the markdown preview function in publish to show a more accurate preview using our current markdown rules (or disable it completely).

@btzr-io btzr-io self-assigned this May 29, 2018

@btzr-io btzr-io referenced this issue May 30, 2018

Merged

Fix markdown preview #1528

2 of 2 tasks complete

@btzr-io btzr-io closed this Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment