New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use router pattern for rendering file viewer #1544

Closed
kauffj opened this Issue Jun 4, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@kauffj
Member

kauffj commented Jun 4, 2018

The app already supports several distinct viewers (video, markdown/html) and this list will only grow.

We ought to use a sensible pattern to handle this case.

For more details, see #1542 (comment)

@kauffj kauffj referenced this issue Jun 4, 2018

Closed

Add 3D file-viewer support #1542

12 of 14 tasks complete

@btzr-io btzr-io self-assigned this Jun 4, 2018

This was referenced Jun 5, 2018

@btzr-io btzr-io referenced this issue Aug 3, 2018

Merged

File viewer v2 #1826

13 of 13 tasks complete
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 10, 2018

Member

Closed in #1576

Member

tzarebczan commented Aug 10, 2018

Closed in #1576

@tzarebczan tzarebczan closed this Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment