New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App page URL issues when app cold starts to rewards page #1549

Closed
tzarebczan opened this Issue Jun 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@tzarebczan
Member

tzarebczan commented Jun 5, 2018

The Issue

On Windows, the app will load but fail to load the special URL (i.e lbry://?rewards) because the ? is not replaced in the createWindow.js file (which is loaded on cold start as opposed to the call in index.js). On Mac, the app will green screen because daemon_settings are not loaded quickly enough.

Fixed in pre-redesign here: 81ce858

Will fix with PR in redesign.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jun 9, 2018

Member

Fixed in #1552

Member

tzarebczan commented Jun 9, 2018

Fixed in #1552

@tzarebczan tzarebczan closed this Jun 9, 2018

@lbry-bot lbry-bot removed the needs: triage label Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment