New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect markdown preview on url with parentheses #1570

Closed
m160 opened this Issue Jun 10, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@m160

m160 commented Jun 10, 2018

The Issue

The link in the markdown preview differs from published description when it's a parentheses in the url.

Steps to Reproduce

  1. Markdown text:
    capture1

  2. Markdown preview:
    capture2

Here it's linking to https://en.wikipedia.org/wiki/Flying_monkeys_(psychology, without the last parentheses in the link so it directs to the incorrect url.

  1. When published it renders correctly though:
    capture3

Expected Behaviour

The markdown preview shouldn't differ from how it will actually appear

System Configuration

  • LBRY Daemon version: 0.19.3
  • LBRY App version: 0.22.0-rc.9
  • LBRY Installation ID: 2XLeCW8MRiQYbQvU57s3aFVvvGFqymwMuBngLZTL9qWHNazFkSauVgyq6Hdib8ieqr
  • Operating system: Windows 10

Anything Else

Another little thing I discovered was that tables don't preview correctly if there nothing in the last cell:
capture4

It should still be grey. It shows up correctly though:
capture5

Not huge issues, just nitpicking.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jun 10, 2018

Member

Thanks @m160 - we like nitpicking

Member

kauffj commented Jun 10, 2018

Thanks @m160 - we like nitpicking

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Jun 10, 2018

Collaborator

There is nothing we can do about the parenthesis bug:

Incorrect link parsing in preview mode #528

It seems that CodeMirror handles the parsing correctly while editing. However, Marked is not parsing it correctly for previewing. Since we depend on this library for SimpleMDE, an issue would need to be submitted with their repository.
sparksuite/simplemde-markdown-editor#528 (comment)

Collaborator

btzr-io commented Jun 10, 2018

There is nothing we can do about the parenthesis bug:

Incorrect link parsing in preview mode #528

It seems that CodeMirror handles the parsing correctly while editing. However, Marked is not parsing it correctly for previewing. Since we depend on this library for SimpleMDE, an issue would need to be submitted with their repository.
sparksuite/simplemde-markdown-editor#528 (comment)

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Jun 10, 2018

Collaborator

Also that's not the only problem with links, here is a full list:
markedjs/marked#984

Collaborator

btzr-io commented Jun 10, 2018

Also that's not the only problem with links, here is a full list:
markedjs/marked#984

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io
Collaborator

btzr-io commented Jun 10, 2018

@tiger5226

This comment has been minimized.

Show comment
Hide comment
@tiger5226

tiger5226 Jun 11, 2018

Member

solved and merged

Member

tiger5226 commented Jun 11, 2018

solved and merged

@tiger5226 tiger5226 closed this Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment