Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't right click > paste into description on publish #1664

Closed
tzarebczan opened this Issue Jun 21, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@tzarebczan
Copy link
Member

tzarebczan commented Jun 21, 2018

The Issue

Can use ctrl-v, but right click doesn't work in Publish > Description. Might be worth looking into other parts of the app also.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@Invariant-Change

This comment has been minimized.

Copy link
Contributor

Invariant-Change commented Jun 21, 2018

The description area needs to be an Input HTMLElement. When I change the span to an input it works. However, it then requires restyling.

<span class="cm-null cm-spell-error">This is the description text area, which is not an Input HTMLElement</span>

The code only lets the context menu work on inputs.

  // If context menu is opened on Input and text is present on clipboard
  if (clipboard.readText().length > 0 && isInput) {
    templates.push({
      label: 'Paste',
      accelerator: 'CmdOrCtrl+V',
      role: 'paste',
    });
  }

See contextMenu.js

Also affects the "Report a Bug or Suggest a New Feature" area.

image

@btzr-io btzr-io self-assigned this Jun 21, 2018

@btzr-io

This comment has been minimized.

Copy link
Collaborator

btzr-io commented Jun 21, 2018

This requires a more complex fix 🙃 ^^
See RIP21/react-simplemde-editor#67

@btzr-io btzr-io added dependencies and removed level: 1 labels Jun 21, 2018

@btzr-io

This comment has been minimized.

Copy link
Collaborator

btzr-io commented Jun 21, 2018

Also I don't think that's the correct style for textarea of dark-theme
@tzarebczan Should we open a new issue for that? ^

@btzr-io btzr-io referenced this issue Jun 21, 2018

Merged

Fix context-menu #1671

3 of 3 tasks complete

@seanyesmunt seanyesmunt closed this Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.