New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout modal needs to be smarter #328

Closed
6ea86b96 opened this Issue Jul 3, 2017 · 4 comments

Comments

Projects
None yet
6 participants
@6ea86b96
Contributor

6ea86b96 commented Jul 3, 2017

The Issue

If a load/download fails, and you are on a different file page, an error modal appears showing the name of the current file, not the one downloading

Steps to reproduce

  1. Try to download an unavailable file
  2. Navigate to a different file
  3. Wait

Expected behaviour

An error modal should appear with the correct file details.

Actual behaviour

An error modal appears with the current file details

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 6, 2017

Member

We definitely need some work on this as the current message is not informative.

For instance, a failed download shows the sdhash
Error message: Failed to download 8a455fb52ac158ec8bb80737dd9dc1e70c25dcd7b6966bc358cc466b78fdcc22c646616ba3decdba906d27f06730ac49 within timeout

Users are not familiar with the SDhash, so the URL should be shown

Member

tzarebczan commented Aug 6, 2017

We definitely need some work on this as the current message is not informative.

For instance, a failed download shows the sdhash
Error message: Failed to download 8a455fb52ac158ec8bb80737dd9dc1e70c25dcd7b6966bc358cc466b78fdcc22c646616ba3decdba906d27f06730ac49 within timeout

Users are not familiar with the SDhash, so the URL should be shown

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 24, 2017

Collaborator

@tzarebczan url is also weird, what about -> title ? ^^

url:lbry://@howCode#ac5a3547b76cfafe393525033887864fa7c73dd6/hc-DIPZoZheMTo
title: Simple Server in Python

Collaborator

btzr-io commented Aug 24, 2017

@tzarebczan url is also weird, what about -> title ? ^^

url:lbry://@howCode#ac5a3547b76cfafe393525033887864fa7c73dd6/hc-DIPZoZheMTo
title: Simple Server in Python

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 24, 2017

Member

Yep, the title seems to make much more sense here, thanks for making that evident.

Member

tzarebczan commented Aug 24, 2017

Yep, the title seems to make much more sense here, thanks for making that evident.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Dec 2, 2017

Member

@seanyesmunt / @liamcardenas - since lbryio/lbry#883 (comment) now shows the URL, we should show that instead of the sd-hash. Ultimately I think we would want to show the title.

Also, maybe we can simplify the popup - doesn't need to say "this error has been reported" but instead explain that it could not download the file at this time, please try again later. If they consistently see this error across multiple files, they should visit https://lbry.io/faq/unable-to-stream (I can beef this up to be more generic). Reasons for download failures could be DHT issues on our side, old content that was never properly seeded, or network issues on the users' side.

When @6ea86b96 originally opened this ticket, I'm not sure if it was showing the incorrect file, maybe just some confusion there. But if you start download A, then go to claim B and while there, download A times out, it still shows the data for download A failure (and not download B as claimed in this ticket).

Member

tzarebczan commented Dec 2, 2017

@seanyesmunt / @liamcardenas - since lbryio/lbry#883 (comment) now shows the URL, we should show that instead of the sd-hash. Ultimately I think we would want to show the title.

Also, maybe we can simplify the popup - doesn't need to say "this error has been reported" but instead explain that it could not download the file at this time, please try again later. If they consistently see this error across multiple files, they should visit https://lbry.io/faq/unable-to-stream (I can beef this up to be more generic). Reasons for download failures could be DHT issues on our side, old content that was never properly seeded, or network issues on the users' side.

When @6ea86b96 originally opened this ticket, I'm not sure if it was showing the incorrect file, maybe just some confusion there. But if you start download A, then go to claim B and while there, download A times out, it still shows the data for download A failure (and not download B as claimed in this ticket).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment