New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain previous screen sizing on startup (LBRY starts maximized) #338

Closed
tzarebczan opened this Issue Jul 7, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@tzarebczan
Member

tzarebczan commented Jul 7, 2017

The Issue

When LBRY is run, the app always goes into full screen mode. We've had a user that mentioned this should not happen or should be configurable. Is it possible to remember the previous window size upon next start up?

If this is the intended functionality to maximize Home page content viewing, so feel free to close.

Steps to reproduce

  1. Launch LBRY
  2. Goes full screen

Expected behaviour

LBRY should either not go in full screen mode or remember previous app close window size

Actual behaviour

Always goes into full screen mode

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 8, 2017

Yes, this is annoying when you have a large screen. Recalling window size is an excellent solution. Thanks for entering this.

ghost commented Jul 8, 2017

Yes, this is annoying when you have a large screen. Recalling window size is an excellent solution. Thanks for entering this.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Jul 10, 2017

Member

Actually, on Windows it does seem to keep the window size to the setting which LBRY was closed. Can someone confirm on Mac? I'll check Ubuntu later.

Member

tzarebczan commented Jul 10, 2017

Actually, on Windows it does seem to keep the window size to the setting which LBRY was closed. Can someone confirm on Mac? I'll check Ubuntu later.

@kauffj kauffj changed the title from App launches in full screen every startup to Retain previous screen sizing on startup Jul 10, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jul 10, 2017

Member

Maximize is called on every run. It's called here: https://github.com/lbryio/lbry-app/blob/fce702f737909d21e9b7581051690f356a82bd56/app/main.js#L155

To address this ticket, size should be saved locally on close and set in the above linked function.

Member

kauffj commented Jul 10, 2017

Maximize is called on every run. It's called here: https://github.com/lbryio/lbry-app/blob/fce702f737909d21e9b7581051690f356a82bd56/app/main.js#L155

To address this ticket, size should be saved locally on close and set in the above linked function.

@akinwale

This comment has been minimized.

Show comment
Hide comment
@akinwale

akinwale Jul 13, 2017

Member

Should the saved width and height override the minWidth and minHeight properties respectively?

Member

akinwale commented Jul 13, 2017

Should the saved width and height override the minWidth and minHeight properties respectively?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 13, 2017

If I were coding this, I'd make sure there was a minimum, because I have seen app windows that became so small by accident, they couldn't be made larger. The minimum could be 800x600 if the remembered size was too small. That size window is actually usable, if not optimal.

ghost commented Jul 13, 2017

If I were coding this, I'd make sure there was a minimum, because I have seen app windows that became so small by accident, they couldn't be made larger. The minimum could be 800x600 if the remembered size was too small. That size window is actually usable, if not optimal.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Jul 13, 2017

Member

Agreed, please retain the minimum @akinwale.

Member

kauffj commented Jul 13, 2017

Agreed, please retain the minimum @akinwale.

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Dec 20, 2017

Member

Per suggestion from a community member: https://github.com/mawie81/electron-window-state

Member

tzarebczan commented Dec 20, 2017

Per suggestion from a community member: https://github.com/mawie81/electron-window-state

@tzarebczan tzarebczan changed the title from Retain previous screen sizing on startup to Retain previous screen sizing on startup (LBRY starts maximized) Dec 20, 2017

@lyoshenka lyoshenka closed this Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment