Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support claims that are also downloaded show in publish, other inconsistencies. #384

Closed
tzarebczan opened this Issue Jul 25, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@tzarebczan
Copy link
Member

tzarebczan commented Jul 25, 2017

The Issue

Originally introduced here: #315

Background: I have added support to lbry://ten at claimid: f4d5521279b783416bf6950b506f852105e8968e

Two main issues arise:

  1. My Publishes page shows support claims for other claims which I have added support to. Since we will be adding Support functionality in the UI, shouldn't LBRY list the supports somewhere? The content we are supporting may or may not be on the Publishes page. We can leave this as another enhancement and fix the immediate issue for now.

  2. Publish page takes my supports into account when determining my ownership of a lbry URI. i.e. I supported lbry://ten, and when I type ten in Publish as a URI, it says I own it.

UPDATE: #1/2 above are still happening in v16 with the caveat that the supported claim needs to be downloaded to reproduce the issue. #2 is compounded on the claim page now because it will show an Edit button.

Steps to reproduce

  1. Add support to a claim
  2. Go to Publishes page, it shows there
  3. Go to Publish page and try to use that URI, it shows as taken
  4. try to go to permanent URL of that claim - empty claim or metadata info.

Expected behaviour

Supports should be disregarded for time being

Actual behaviour

Supports mess up Publishes/Publish

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

have claim support shows as my claim
empty
publishes

@tzarebczan

This comment has been minimized.

Copy link
Member Author

tzarebczan commented Jul 26, 2017

Found another issue related to above. When I go to lbry://ten, it also thinks I own the file and can't download it / but it prompts me to abandon my claim. Removing it does nothing, goes back to "Open" state.
10

@tzarebczan tzarebczan changed the title Issues with Support Claims and Publish functions Support claims that are also downloaded show in publish, other inconsistencies. Sep 19, 2017

@tzarebczan

This comment has been minimized.

Copy link
Member Author

tzarebczan commented Sep 19, 2017

UPDATE: #1/2 above are still happening in v16 with the caveat that the supported claim needs to be downloaded to reproduce the issue. #2 is compounded on the claim page now because it will show an Edit button. #3 still happened to me, but I used the incorrect claim_id, so that was an error on my part.

holi2

@tzarebczan

This comment has been minimized.

Copy link
Member Author

tzarebczan commented Sep 20, 2017

And he's a screenshot for the edit button of a claim I don't own (but support)
notmyfile

@alyssaoc

This comment has been minimized.

Copy link
Member

alyssaoc commented Aug 21, 2018

@tzarebczan is this still happening?

@alyssaoc

This comment has been minimized.

Copy link
Member

alyssaoc commented Dec 7, 2018

closing, reopen if this is still an issue

@alyssaoc alyssaoc closed this Dec 7, 2018

@tzarebczan

This comment has been minimized.

Copy link
Member Author

tzarebczan commented Dec 7, 2018

There's a newer issue filed for this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.