Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos inappropriately aligned if 4:3 or vertical #419

Closed
tzarebczan opened this Issue Aug 1, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@tzarebczan
Copy link
Member

tzarebczan commented Aug 1, 2017

The Issue

Take this video as an example: lbry://nightofthelivingdead#e59cb8ee903d9c38c2563e2200026aec1be638fd

The streaming screen could look a bit better in terms of aesthetics for videos with odd resolutions. It almost looks like it's cutting off. Maybe center or size the player accordingly? See screenshot below

Steps to reproduce

  1. Stream lbry://nightofthelivingdead#e59cb8ee903d9c38c2563e2200026aec1be638fd

Expected behaviour

Can be displayed better

Actual behaviour

looks broken

System Configuration

  • LBRY Daemon version: 0.14.2
  • LBRY App version: 0.14.2
  • LBRY Installation ID:
  • Operating system: Windows 10

Anything Else

Screenshots

video cutting off

@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Aug 1, 2017

Duplicate of #409

@kauffj kauffj marked this as a duplicate of #409 Aug 1, 2017

@kauffj kauffj closed this Aug 1, 2017

@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Aug 1, 2017

I suppose yours is better.

@kauffj kauffj reopened this Aug 1, 2017

@kauffj kauffj changed the title In-app player and video resolutions Videos inappropriately aligned if 4:3 or vertical Aug 1, 2017

hackrush01 added a commit to hackrush01/lbry-app that referenced this issue Aug 4, 2017

Fixes alignment problems in some videos
Couldn't break anything else after this fix, and the broken videos
_were_ fixed. So I guess this is a proper fix, but not sure(if it was
this simple or not).

Fixes lbryio#419

@btzr-io btzr-io referenced this issue Aug 9, 2017

Merged

Fix video width #457

@kauffj kauffj closed this in #457 Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.