New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs allow negative value #441

Closed
btzr-io opened this Issue Aug 6, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@btzr-io
Collaborator

btzr-io commented Aug 6, 2017

The Issue

The claim deposit input inside publish page allows a negative value.

Steps to reproduce

  1. Open publish page
  2. Go to Content URL > deposit
  3. Add a negative value.

Expected behaviour

It should probably allow 0 or minimum but not negative.

Actual behaviour

A negative value it's assigned,

System Configuration

Configuration Version
App 0.14.3
Daemon (lbrynet) 0.14.2
Wallet (lbryum) 3.1.4
Platform Linux (Linux-4.10.0-28-generic-x86_64-with-elementary-0.4.1-loki)

Screenshots

negative

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 6, 2017

Collaborator
Collaborator

btzr-io commented Aug 6, 2017

@btzr-io btzr-io changed the title from Claim deposit input allows negative value to Inputs allow negative value Aug 6, 2017

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 7, 2017

Member

Don't think #398 has anything to do with this one.

Member

tzarebczan commented Aug 7, 2017

Don't think #398 has anything to do with this one.

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 8, 2017

Collaborator

ok, I was just pointing out a similar issue,
they are kind of related because both of them are: ux-issue

Collaborator

btzr-io commented Aug 8, 2017

ok, I was just pointing out a similar issue,
they are kind of related because both of them are: ux-issue

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 8, 2017

Collaborator

Less then two. I understand that this is not critical issue. I think you can change it to something like "pending" instead of negative value.

Collaborator

btzr-io commented Aug 8, 2017

Less then two. I understand that this is not critical issue. I think you can change it to something like "pending" instead of negative value.

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Aug 12, 2017

Member

Fixed in Publish page, as well as in all LBC/USD hybrid inputs.

Member

kauffj commented Aug 12, 2017

Fixed in Publish page, as well as in all LBC/USD hybrid inputs.

@kauffj kauffj closed this Aug 12, 2017

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 12, 2017

Collaborator

are you sure?? ^^ what about? -> #471

Collaborator

btzr-io commented Aug 12, 2017

are you sure?? ^^ what about? -> #471

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Aug 12, 2017

Member

Merged #471.

Member

kauffj commented Aug 12, 2017

Merged #471.

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 12, 2017

Collaborator

Also I think maybe would be better to set the formFieldPrice default prop min to 0 🙃

Collaborator

btzr-io commented Aug 12, 2017

Also I think maybe would be better to set the formFieldPrice default prop min to 0 🙃

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Aug 12, 2017

Member

If themin isn't a multiple of step, Chrome has some undesirable behavior when using the arrows (e.g. it will step 5 down to 4.91, with min=0.01 and step=0.1).

Member

kauffj commented Aug 12, 2017

If themin isn't a multiple of step, Chrome has some undesirable behavior when using the arrows (e.g. it will step 5 down to 4.91, with min=0.01 and step=0.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment