New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content has a tiny LBC fee but shown as Free in app (requires payment) #461

Closed
tzarebczan opened this Issue Aug 9, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented Aug 9, 2017

The Issue

If the content fee is a small LBC value, like 0.01, it is shown as Free on the app even though it requires a payment. Take this instance this published item: lbry://pascalcoinwalletb21202#e5a47c49c9d8b7a58dfb719992248265adfa75a3 the fee was set to 0.01 LBC but if navigating with app, it is shown as free. When you go to purchase it, you get a pop-up that says "This will purchase [content] for free credits".

Not sure what the threshold is exactly, but we need to be more precise with our fees.

Steps to reproduce

  1. Publish content with a small LBC fee value
  2. Content will show up as free

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

free credits

@tzarebczan tzarebczan added the type: bug label Aug 9, 2017

@btzr-io btzr-io referenced this issue Aug 10, 2017

Closed

Fix CreditAmount #465

0 of 1 task complete
@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 10, 2017

Collaborator

The problem is that price is getting formated toFixed ^^

Collaborator

btzr-io commented Aug 10, 2017

The problem is that price is getting formated toFixed ^^

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 10, 2017

Collaborator

This is the current logic: 0.01999 -> 0.01 -> 0.0 -> 0 > free

Collaborator

btzr-io commented Aug 10, 2017

This is the current logic: 0.01999 -> 0.01 -> 0.0 -> 0 > free

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 10, 2017

Collaborator

I know this: 0.0019999999 looks ugly but I think the app should be more transparent about prices 😛

Collaborator

btzr-io commented Aug 10, 2017

I know this: 0.0019999999 looks ugly but I think the app should be more transparent about prices 😛

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 10, 2017

Collaborator

Alternative -> show a small button / add a settings option to display full price:

0.01 [...] -> 0.019999987
Collaborator

btzr-io commented Aug 10, 2017

Alternative -> show a small button / add a settings option to display full price:

0.01 [...] -> 0.019999987
@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Aug 10, 2017

Collaborator

fix-price

Collaborator

btzr-io commented Aug 10, 2017

fix-price

kauffj added a commit that referenced this issue Aug 11, 2017

init fix for #461
use `===` instead of `==`

don't format prices

increase price precision
@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Aug 11, 2017

Member

I added a "<" symbol for when we are below the smallest renderable value and reduced the default precision to 2. Right now 0.01 LBC is less than a penny, so I'm not particularly concerned with more precision.

Member

kauffj commented Aug 11, 2017

I added a "<" symbol for when we are below the smallest renderable value and reduced the default precision to 2. Right now 0.01 LBC is less than a penny, so I'm not particularly concerned with more precision.

@kauffj kauffj closed this Aug 11, 2017

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 18, 2017

Member

@btzr-io -
Found an issue when downloading lbry://eight on the latest master. I like how it shows <0.01 LBC as the price, but when streaming/downloading, there is no confirmation box to purchase the content even though 0.01 LBC is charged.

There is also this change going in soon: lbryio/lbry#835 so not sure if that fixes/affects it.

Member

tzarebczan commented Aug 18, 2017

@btzr-io -
Found an issue when downloading lbry://eight on the latest master. I like how it shows <0.01 LBC as the price, but when streaming/downloading, there is no confirmation box to purchase the content even though 0.01 LBC is charged.

There is also this change going in soon: lbryio/lbry#835 so not sure if that fixes/affects it.

@tzarebczan tzarebczan reopened this Aug 18, 2017

@btzr-io btzr-io referenced this issue Aug 23, 2017

Closed

Fix for #461 #490

5 of 5 tasks complete
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Aug 23, 2017

Member

@kauffj When they go to purchase the content, you want it also to show <0.01 LBC or show the exact price of the content in the purchase confirmation screen?

Member

tzarebczan commented Aug 23, 2017

@kauffj When they go to purchase the content, you want it also to show <0.01 LBC or show the exact price of the content in the purchase confirmation screen?

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Aug 23, 2017

Member

Confirmation dialog should show the full price. It would also be a good idea to put the full price as a title attribute on the element when showing "<0.01" so the full price can be seen on mouseover.

Member

kauffj commented Aug 23, 2017

Confirmation dialog should show the full price. It would also be a good idea to put the full price as a title attribute on the element when showing "<0.01" so the full price can be seen on mouseover.

kauffj added a commit that referenced this issue Aug 25, 2017

Fix for #461
show full price on confirmation

don't format full price

smart format for full price
@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Aug 25, 2017

Member

Fixed in c03c0de

Member

kauffj commented Aug 25, 2017

Fixed in c03c0de

@kauffj kauffj closed this Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment