New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind enter key press to form submission as appropriate #542

Closed
tzarebczan opened this Issue Sep 8, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented Sep 8, 2017

The Issue

If you try to use the Enter key to send credits on the Send screen or send an invite on the Invites screen, the page reloads and nothing happens

Steps to reproduce

  1. Go to Send screen, enter amount and address, press Enter
  2. Go to invite screen, enter email to invite, press Enter

Expected behaviour

Enter key should be allowed to confirm action

Actual behaviour

Enter key refreshes page.

System Configuration

  • LBRY Daemon version: 0.15.1
  • LBRY App version: 0.15.1
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

@kauffj kauffj changed the title from Enter key causes Send / Invites screen to refresh and not complete action to Bind enter to form submission as appropriate Sep 8, 2017

@kauffj kauffj changed the title from Bind enter to form submission as appropriate to Bind enter key press to form submission as appropriate Sep 8, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 8, 2017

Member

@tzarebczan re-titled to the solution I'd like to see.

Member

kauffj commented Sep 8, 2017

@tzarebczan re-titled to the solution I'd like to see.

btzr-io added a commit that referenced this issue Sep 11, 2017

fix #542
implement submit component

fix weird behaviour in wallet send

prevent refresh on enter key

@btzr-io btzr-io referenced this issue Sep 11, 2017

Merged

Form component #550

@btzr-io

This comment has been minimized.

Show comment
Hide comment
@btzr-io

btzr-io Sep 11, 2017

Collaborator

should all forms have this behavior ( publish form... ) ?

Collaborator

btzr-io commented Sep 11, 2017

should all forms have this behavior ( publish form... ) ?

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 11, 2017

Member

Publish probably shouldn't?

(It should only be happening when an input or label is not focused, regardless)

Member

kauffj commented Sep 11, 2017

Publish probably shouldn't?

(It should only be happening when an input or label is not focused, regardless)

kauffj added a commit that referenced this issue Sep 18, 2017

fix #542
implement submit component

fix weird behaviour in wallet send

prevent refresh on enter key

fix wallet send ->  submit handler

implement form component

fix conflicts

remove unused files

better submit handler

better validation for walletSend

prevent / remove missign parameters error (popup)

minor fix

minor fix for submit validation in walletSend

@kauffj kauffj closed this in #550 Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment