New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking claim in Invites screen causes console error #552

Closed
tzarebczan opened this Issue Sep 11, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@tzarebczan
Member

tzarebczan commented Sep 11, 2017

The Issue

I already redeemed a referral reward and now when I try to claim another, I don't get any feedback but instead a console error is thrown. Earlier last week I remember getting a "You already redeemed your max reward for this" message.

bundle.js:17726 Uncaught TypeError: Cannot read property 'reward_type' of undefined
    at claimReward (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:17726:62)
    at onClick (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:36442:9)
    at Object.ReactErrorUtils.invokeGuardedCallback (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:16100:16)
    at executeDispatch (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15629:21)
    at Object.executeDispatchesInOrder (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:15652:5)
    at executeDispatchesAndRelease (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10245:22)
    at executeDispatchesAndReleaseTopLevel (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10256:10)
    at Array.forEach (native)
    at forEachAccumulated (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:26138:9)
    at Object.processEventQueue (file:///C:/Program%20Files%20(x86)/LBRY/resources/app/dist/js/bundle.js:10456:7)

Steps to reproduce

  1. Click Claim in Invites screen
  2. Nothing happens, check console
  3. Console has error

Expected behaviour

Tell me that I'm maxed out

Actual behaviour

Nothing, console error

System Configuration

  • LBRY Daemon version: 0.15.2
  • LBRY App version: 0.15.1
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

@kauffj kauffj added this to the September 18 milestone Sep 12, 2017

@kauffj kauffj assigned kauffj and tzarebczan and unassigned kauffj Sep 12, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 18, 2017

Member

@tzarebczan please verify this is fixed once you see a v0.16 app draft or RC posted. If fixed, close, if not, reassign to me.

Member

kauffj commented Sep 18, 2017

@tzarebczan please verify this is fixed once you see a v0.16 app draft or RC posted. If fixed, close, if not, reassign to me.

@kauffj kauffj closed this Sep 18, 2017

@kauffj kauffj reopened this Sep 18, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj
Member

kauffj commented Sep 19, 2017

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Sep 22, 2017

Member

Reopening so we can track this, lower priority for now.

Member

tzarebczan commented Sep 22, 2017

Reopening so we can track this, lower priority for now.

@tzarebczan tzarebczan reopened this Sep 22, 2017

@kauffj

This comment has been minimized.

Show comment
Hide comment
@kauffj

kauffj Sep 22, 2017

Member

I thought this error was fixed and it was more of a UX issue at this point?

Member

kauffj commented Sep 22, 2017

I thought this error was fixed and it was more of a UX issue at this point?

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Sep 22, 2017

Member

Nope, still there. I think it was suppressed on the original v16RC when my transaction list was broken. #588 (comment) shows the code its failing on. It could be related to the fact that I redeemed all my rewards?

I'd say its low priority, I haven't seen this from anyone else.

Member

tzarebczan commented Sep 22, 2017

Nope, still there. I think it was suppressed on the original v16RC when my transaction list was broken. #588 (comment) shows the code its failing on. It could be related to the fact that I redeemed all my rewards?

I'd say its low priority, I haven't seen this from anyone else.

@liamcardenas

This comment has been minimized.

Show comment
Hide comment
@liamcardenas

liamcardenas Nov 17, 2017

Contributor

@tzarebczan can you see if this is still happening?

Contributor

liamcardenas commented Nov 17, 2017

@tzarebczan can you see if this is still happening?

@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Dec 8, 2017

Member

Yep, still happening (only on 2nd claim, not first) This is the line:

`  return dispatch((0, _rewards2.doClaimRewardType)(reward.reward_type, true));`
Member

tzarebczan commented Dec 8, 2017

Yep, still happening (only on 2nd claim, not first) This is the line:

`  return dispatch((0, _rewards2.doClaimRewardType)(reward.reward_type, true));`
@tzarebczan

This comment has been minimized.

Show comment
Hide comment
@tzarebczan

tzarebczan Dec 15, 2017

Member

Closing this in favor of #829

Member

tzarebczan commented Dec 15, 2017

Closing this in favor of #829

@tzarebczan tzarebczan closed this Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment